status change email has wrong 'From'

[Robert Collins]

I just changed the status on a bug via betas web ui.

The message sent to me claims to be from Jelmer, even though I made the
change to the bug. This is clearly bogus.

 affects /products/launchpad

Rob

Return-path: <email address hidden>
X-Spam-Checker-Version: SpamAssassin 3.1.4 (2006-07-26) on
        lifelesswks.robertcollins.net
X-Spam-Level:
X-Spam-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,
        MSGID_MULTIPLE_AT autolearn=no version=3.1.4
Envelope-to: <email address hidden>
Delivery-date: Wed, 21 Mar 2007 15:06:53 +1100
Received: from adelie.ubuntu.com ([82.211.81.139]) by
        lifelesswks.robertcollins.net with esmtp (Exim 4.62)
(envelope-from
        <email address hidden>) id 1HTs68-000785-O0 for
<email address hidden>;
        Wed, 21 Mar 2007 15:06:53 +1100
Received: from gangotri.ubuntu.com ([82.211.81.179]) by
adelie.ubuntu.com
        with esmtp (Exim 4.60 #1 (Debian)) id 1HTs61-0003hn-Ko for
        <email address hidden>; Wed, 21 Mar 2007 04:06:45 +0000
Received: from gangotri.ubuntu.com (localhost.localdomain [127.0.0.1])
by
        gangotri.ubuntu.com (Postfix) with ESMTP id 77462318056 for
        <email address hidden>; Wed, 21 Mar 2007 04:06:45 +0000
(GMT)
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
X-Launchpad-Bug: product=bzr; status=Fix Released; importance=Medium;
        <email address hidden>;
Reply-To: Bug 50329 <email address hidden>
References: <email address hidden>
To: <email address hidden>
From: Jelmer Vernooij <email address hidden>
Subject: [Bug 50329] commit code requires plugins to be loaded
Message-Id:
<20070321040645.10749.54470.launchpad@<email address hidden>>
Date: Wed, 21 Mar 2007 04:06:45 -0000
Sender: <email address hidden>
Errors-To: <email address hidden>
X-Generated-By: Launchpad (canonical.com)
X-Evolution-Source: imap://robertc@localhost/

Public bug reported:

Current bzr.dev will bail out if it's being used from an external
application that doesn't load bzrs plugins. The commit code will throw a
confusing exception in the post_commit code if this happens.

We should skip plugins if none are loaded or make sure there's at least
always an empty list there.

** Affects: bzr (upstream)
     Importance: Medium
     Assignee: Robert Collins
         Status: Fix Released

-- =

commit code requires plugins to be loaded
https://beta.launchpad.net/bugs/50329

--
GPG key available at: <http://www.robertcollins.net/keys.txt>.

[James Henstridge (jamesh)]

You'll also notice that the comment is not the one you made, but Jelmer's initial comment on the bug. This is one of the emails giving an initial description of the bug to new subscribers.

It is a bit confusing because it gives the initial bug description, but the current status information. I am sure there is a bug about that issue though ...

[Christian Reis (kiko)]

Well, the bug that exists is about the email, and I've fixed tht together with bug 3797. However, I'd like to keep this bug open and confirmed because I don't intend to change the From: address in the same patch. My patch has an XXX for this issue.

Rob, what From: address would make sense to you?

[Robert Collins (lifeless)]

On Wed, 2007-03-21 at 13:28 +0000, Christian Reis wrote:
> Well, the bug that exists is about the email, and I've fixed tht
> together with bug 3797. However, I'd like to keep this bug open and
> confirmed because I don't intend to change the From: address in the same
> patch. My patch has an XXX for this issue.
>
> Rob, what From: address would make sense to you?

Lets say that two different people change the bug within the
notification batch time.

I'd expect one email from each person, with the status as they changed
it. This isn't a violation of batching IMO.

Alternatively, one email with the From: address being the address of the
bug in launchpad - <email address hidden>.

The latter solution may be better because its easier to implement, and
it does not expose the users email address (which they may well have
configured launchpad to hide).

Rob
--
GPG key available at: <http://www.robertcollins.net/keys.txt>.

[Björn Tillenius (bjornt)]

This is needed for the implementation of the debian-bug-import-on-demand spec, which may create bugs having invalid Persons as the reporter.

[Gavin Panella (allenap)]

Rocketfuel r4710