Missing user generates a TypeError

Bug #941856 reported by Aurélien Bompard
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
txAMQP
Fix Released
Medium
Unassigned

Bug Description

If I try to log on to an AMQP server with a wrong username, I get a TypeError because of a bug in client.py.

The very last line of the file is :

  self.client.started.fail_if_not_fired(reason)

it should read :

  self.client.started.fail_if_not_fired(Closed(reason))

The "reason" here is a Message instance. If it is not wrapped in an exception, a TypeError will be raised when the deferred's "errback" method is called (in _fire_deferred, same file)

Here's some code to demonstrate it : http://pastebin.com/qUUe8LfY

Revision history for this message
Esteve Fernandez (esteve) wrote :

Fixed in trunk. Thanks a lot for the patch!

Changed in txamqp:
importance: Undecided → Medium
status: New → Fix Committed
Changed in txamqp:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.