Webkit greeter lacks an User Pic support.

[Andrea Virgillito]

Why don't we put an user pic nearby the account selection area? I think it's a good idea to focus better the selected user, together with the wallpaper transition effect.

[Brice Terzaghi (terzag)]

Not sure if this is the place to report this but I'm currently developing a lightdm webkit theme and have problems with user pics.

In the original theme, user pic is displayed but there is a bug if the user has no pic (i.e. no ~/.face file) : rather than displaying the stock person icon, it displays the webkit missing file icon.

This comes from the fact that the code checks if user.image.length is > 0, assuming that if the file exists, length will be > 0 and it will be = 0 if the file doesn't exists. Well, that's wrong: user.image is a string ("/home/username/.face") which is sent back by LightDM (or the LightDM WebKit engine specifically? I have no experience with other greeters or LightDM in general) even if the file doesn't exist. So the theme always thinks a ~/.face file exists, even if it's not the case.

Either this is a bug in the LightDM webkit engine (maybe it should send back an empty string for user.image if ~/.face or ~/.face.icon doesn't exists?) or it's not and in that case the existence of the file has to be tested through JavaScript (which is not an easy task, although it might be possible with the new File API of HTML 5).

[Filip (wattos-o)]

This is not really a major bug and can be easily worked around by doing the following in your javascript:

    if (user.image) {
      image.src = user.image
      image.onerror= function(e) {
        e.currentTarget.src= "img/avatar.svg";
      }
    } else {
      image.src = "img/avatar.svg";
    }

As a matter of fact, you should do that anyway, because there is no guarantee that the user pic still exists (it could have been deleted by the user from the system). So in that case your theme would show a backup anyway.

[Andrea Virgillito (andrea900)]

Great news!
What about the release date?

[Lionel Le Folgoc (mrpouit)]

1.5.1 has just been released (there's still some ui work in progress, it's not included yet, should land in 1.5.2 next sunday hopefully).

[Lionel Le Folgoc (mrpouit)]

I mean, the ui rework isn't included (user-avatar support is)

[Andrea Virgillito (andrea900)]

http://bazaar.launchpad.net/~ochosi/+junk/lightdm-gtk-greeter/revision/76 ?

Btw, thanks a lot for your infos!

[Lionel Le Folgoc (mrpouit)]

http://bazaar.launchpad.net/~lightdm-gtk-greeter-team/lightdm-gtk-greeter/1.6/revision/76 is the commit for the 1.6 branch.