SolidFire ISCSI Driver is not populating the Lun field on volume creation

[John Griffith]

The SolidFireSanISCSIDriver currently only populates the 'iscsi_portal' and 'iqn' fields of provider_location. The result is that when attempting to attach an SF Volume to an instance, new multi-lun features added to the Volume Driver will cause a default value of lun = 1 to be used which is invalid for SF devices (all Volumes are lun 0).

To fix this we simply need to add the lun number to the model_update['provider_location'] on Volume creation. I have the change tested, just need a bug to get into Geritt.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/4403

[Devin Carlen (devcamcar)]

Please use "Fix Committed" only when the code has landed and is no longer in review. In fact, Jenkins will even do this for you.

[John Griffith (john-griffith)]

Thanks Devin... sorry about that.

On Thu, Feb 23, 2012 at 5:56 PM, Devin Carlen <email address hidden> wrote:
> Please use "Fix Committed" only when the code has landed and is no
> longer in review.  In fact, Jenkins will even do this for you.
>
> ** Changed in: nova
>       Status: Fix Committed => In Progress
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/938876
>
> Title:
>  SolidFire ISCSI Driver is not populating the Lun field on volume
>  creation
>
> Status in OpenStack Compute (Nova):
>  In Progress
>
> Bug description:
>  The SolidFireSanISCSIDriver currently only populates the
>  'iscsi_portal' and 'iqn' fields of provider_location.  The result is
>  that when attempting to attach an SF Volume to an instance, new multi-
>  lun features added to the Volume Driver will cause a default value of
>  lun = 1 to be used which is invalid for SF devices (all Volumes are
>  lun 0).
>
>  To fix this we simply need to add the lun number to the
>  model_update['provider_location']  on Volume creation.  I have the
>  change tested,  just need a bug to get into Geritt.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/nova/+bug/938876/+subscriptions

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/4403
Committed: http://github.com/openstack/nova/commit/0c483d1970879cf04a2f1ba2119b0ed6605f39b1
Submitter: Jenkins
Branch: master

commit 0c483d1970879cf04a2f1ba2119b0ed6605f39b1
Author: john-griffith <email address hidden>
Date: Wed Feb 22 11:42:08 2012 -0700

    Add lun number to provider_location in create_volume
    * Fixes bug 938876

    Change-Id: I22ccda1df7a0b718697588b0a808af5c58181ed8

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: milestone-proposed
Review: https://review.openstack.org/4716

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/4716
Committed: http://github.com/openstack/nova/commit/f7f15f10691c1eb7921e8f998b0b9b264b0c8d5f
Submitter: Jenkins
Branch: milestone-proposed

commit f7f15f10691c1eb7921e8f998b0b9b264b0c8d5f
Author: john-griffith <email address hidden>
Date: Wed Feb 22 11:42:08 2012 -0700

    Add lun number to provider_location in create_volume
    * Fixes bug 938876

    Change-Id: I22ccda1df7a0b718697588b0a808af5c58181ed8