Incorrect IP for x11vnc -allow option

[Robert Wolf]

Hallo,

there is typo in the code of _broadcastScreen()

              self.vncserver = subprocess.Popen(['x11vnc', '-noshm', '-nopw',
                  '-quiet', '-viewonly', '-shared', '-forever', '-nolookup',
                  '-24to32', '-rfbport', str(self.vncport), '-allow',
                  '127.,192.168.,10.,169.254.' ])

in file /usr/lib/python2.6/dist-packages/epoptes/ui/gui.py. This list should be list of private ranges 192.168.X.X, 10.X.X.X and 172.X.X.X, but there is "127." instead of "172." written.

In the network 172.X.X.X will not broadcast screen.

Regards,

Robert Wolf.

[Fotis Tsamis (ftsamis)]

Hi Robert and thank you for reporting this bug!

Indeed we need to allow the range 172.16.0.0 - 172.31.255.255 too. Maybe a better idea would be to detect the current ip range of the network and allow only this.
The 127. range though is needed because that's what the thin clients use to connect to the server.

[Robert Wolf (r-wolf-conf)]

Hallo,

oh I see now ... Thin client is running on server, only screen is transferred to thin client monitor so epoptes makes connection to the same host as running ... OK, correct. Then, as you said, 172. net is missing. OK.

Regards,

Robert Wolf.

BTW: I have to write this: GREAT Work!

I have tested epoptes last thursday and it is stable, working without any problem and so easy and clean design, so I could make our local changes, although I have no idea about Python and/or PyGTK. Some of these changes I could provide here, e.g. studentDemo (streaming one student to other students and teacher). When I have more time, I try to contact developers if my changes can be usefull.

[Alkis Georgopoulos (alkisg)]

Fix committed in http://bazaar.launchpad.net/~epoptes/epoptes/trunk/revision/230

[Alkis Georgopoulos (alkisg)]

Fix released in Epoptes 0.5.0.