Code cleanup: remove commented out code
Bug #937795 reported by
Henning Gerhardt
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Goobi.Production |
Fix Released
|
Wishlist
|
Henning Gerhardt | ||
| 1.7 |
Fix Released
|
Wishlist
|
Henning Gerhardt | ||
Bug Description
There are many lines of code which are comment out or totally unused as reported by code analyse tools.
If this lines of code are removed it could help in many ways for further code refactoring or cleanup.
Related branches
lp:~henning-gerhardt/goobi-production/bug-937795
- Ralf Claussnitzer (community): Approve
-
Diff: 6072 lines (+196/-2371) (has conflicts)114 files modifiedsrc/de/sub/goobi/beans/Benutzer.java (+0/-3)
src/de/sub/goobi/beans/Prozess.java (+0/-3)
src/de/sub/goobi/beans/Schritt.java (+0/-9)
src/de/sub/goobi/beans/property/DisplayPropertyList.java (+0/-11)
src/de/sub/goobi/config/ConfigOpac.java (+1/-1)
src/de/sub/goobi/config/ConfigOpacCatalogue.java (+1/-4)
src/de/sub/goobi/export/dms/ExportDms.java (+0/-8)
src/de/sub/goobi/export/dms/ExportDms_CorrectRusdml.java (+1/-206)
src/de/sub/goobi/export/download/ExportMets.java (+0/-2)
src/de/sub/goobi/export/download/Multipage.java (+1/-15)
src/de/sub/goobi/export/download/TiffHeader.java (+3/-153)
src/de/sub/goobi/forms/AdministrationForm.java (+4/-275)
src/de/sub/goobi/forms/AktuelleSchritteForm.java (+2/-40)
src/de/sub/goobi/forms/BenutzergruppenForm.java (+1/-3)
src/de/sub/goobi/forms/BenutzerverwaltungForm.java (+3/-8)
src/de/sub/goobi/forms/HelperForm.java (+1/-36)
src/de/sub/goobi/forms/LdapGruppenForm.java (+1/-3)
src/de/sub/goobi/forms/LoginForm.java (+9/-1)
src/de/sub/goobi/forms/LongRunningTasksForm.java (+1/-9)
src/de/sub/goobi/forms/ModuleServerForm.java (+2/-24)
src/de/sub/goobi/forms/NavigationForm.java (+0/-10)
src/de/sub/goobi/forms/ProjekteForm.java (+2/-6)
src/de/sub/goobi/forms/ProzesskopieForm.java (+4/-54)
src/de/sub/goobi/forms/ProzessverwaltungForm.java (+0/-27)
src/de/sub/goobi/forms/RegelsaetzeForm.java (+1/-3)
src/de/sub/goobi/forms/SessionForm.java (+9/-9)
src/de/sub/goobi/forms/SpracheForm.java (+3/-3)
src/de/sub/goobi/forms/StatistikForm.java (+1/-1)
src/de/sub/goobi/helper/BeanHelper.java (+2/-2)
src/de/sub/goobi/helper/FileUtils.java (+0/-5)
src/de/sub/goobi/helper/GoobiScript.java (+0/-33)
src/de/sub/goobi/helper/Helper.java (+2/-39)
src/de/sub/goobi/helper/HelperSchritte.java (+4/-22)
src/de/sub/goobi/helper/Page.java (+1/-89)
src/de/sub/goobi/helper/ProjectHelper.java (+0/-8)
src/de/sub/goobi/helper/ScriptThread.java (+2/-2)
src/de/sub/goobi/helper/TreeNode.java (+0/-1)
src/de/sub/goobi/helper/UghHelper.java (+1/-1)
src/de/sub/goobi/helper/VariableReplacer.java (+1/-9)
src/de/sub/goobi/helper/WebDav.java (+0/-19)
src/de/sub/goobi/helper/encryption/DesEncrypter.java (+3/-3)
src/de/sub/goobi/helper/encryption/TODO (+0/-2)
src/de/sub/goobi/helper/enums/PropertyType.java (+1/-1)
src/de/sub/goobi/helper/exceptions/GUIExceptionWrapper.java (+0/-1)
src/de/sub/goobi/helper/ldap/Ldap.java (+0/-9)
src/de/sub/goobi/helper/servletfilter/HibernateSessionFilter2.java (+1/-3)
src/de/sub/goobi/helper/servletfilter/RequestControlFilter.java (+1/-10)
src/de/sub/goobi/helper/servletfilter/SessionCounterFilter.java (+1/-16)
src/de/sub/goobi/helper/tasks/CreatePdfFromServletThread.java (+0/-10)
src/de/sub/goobi/helper/tasks/LongRunningTaskManager.java (+1/-1)
src/de/sub/goobi/helper/tasks/ProcessSwapInTask.java (+1/-2)
src/de/sub/goobi/helper/tasks/ProcessSwapOutTask.java (+0/-1)
src/de/sub/goobi/helper/tasks/TiffWriterTask.java (+1/-12)
src/de/sub/goobi/importer/Import.java (+0/-27)
src/de/sub/goobi/importer/ImportOpac.java (+7/-69)
src/de/sub/goobi/importer/ImportRussland.java (+8/-33)
src/de/sub/goobi/importer/ImportZentralblatt.java (+7/-38)
src/de/sub/goobi/metadaten/MetaPerson.java (+1/-1)
src/de/sub/goobi/metadaten/Metadaten.java (+14/-97)
src/de/sub/goobi/metadaten/MetadatenHelper.java (+2/-12)
src/de/sub/goobi/metadaten/MetadatenImagesHelper.java (+4/-9)
src/de/sub/goobi/metadaten/MetadatenSperrung.java (+0/-6)
src/de/sub/goobi/metadaten/MetadatenVerifizierung.java (+5/-31)
src/de/sub/goobi/modul/ExtendedDataImpl.java (+2/-2)
src/de/sub/goobi/modul/ExtendedProzessImpl.java (+0/-1)
src/de/sub/goobi/modul/ModulListener.java (+1/-10)
src/de/sub/goobi/persistence/HibernateSessionConversationFilter.java (+1/-6)
src/de/sub/goobi/persistence/HibernateSessionConversationFilterWithoutTransaction.java (+1/-43)
src/de/sub/goobi/persistence/HibernateSessionLong.java (+0/-1)
src/de/sub/goobi/persistence/HibernateUtilOld.java (+3/-16)
src/de/sub/goobi/persistence/ProjektDAO.java (+0/-10)
src/de/sub/goobi/statistik/StatistikStatus.java (+0/-1)
src/de/sub/goobi/statistik/TODO (+0/-2)
src/de/unigoettingen/sub/search/opac/Catalogue.java (+1/-2)
src/de/unigoettingen/sub/search/opac/GetOpac.java (+1/-74)
src/de/unigoettingen/sub/search/opac/Query.java (+1/-3)
src/org/goobi/production/api/property/xmlbasedprovider/impl/Parser.java (+0/-5)
src/org/goobi/production/api/property/xmlbasedprovider/impl/PropertyTemplate.java (+5/-20)
src/org/goobi/production/api/property/xmlbasedprovider/impl/XMLBasedPropertyTemplateProvider.java (+2/-8)
src/org/goobi/production/chart/HibernateProjectTaskList.java (+0/-7)
src/org/goobi/production/chart/HibernateProjectionProjectTaskList.java (+0/-1)
src/org/goobi/production/cli/CommandLineInterface.java (+0/-1)
src/org/goobi/production/cli/helper/CopyProcess.java (+7/-110)
src/org/goobi/production/export/ExportXmlLog.java (+10/-24)
src/org/goobi/production/flow/jobs/HistoryAnalyserJob.java (+2/-22)
src/org/goobi/production/flow/jobs/HistoryAnalyserJob2.java (+2/-21)
src/org/goobi/production/flow/jobs/HistoryJob.java (+2/-21)
src/org/goobi/production/flow/jobs/LuceneIndexJobIDVersion.java (+1/-1)
src/org/goobi/production/flow/jobs/TODO (+0/-2)
src/org/goobi/production/flow/statistics/StatisticsManager.java (+0/-46)
src/org/goobi/production/flow/statistics/hibernate/FilterHelper.java (+4/-8)
src/org/goobi/production/flow/statistics/hibernate/StatQuestProduction.java (+0/-2)
src/org/goobi/production/flow/statistics/hibernate/StatQuestProjectAssociations.java (+0/-1)
src/org/goobi/production/flow/statistics/hibernate/StatQuestProjectProgressData.java (+3/-8)
src/org/goobi/production/flow/statistics/hibernate/StatQuestStorage.java (+0/-2)
src/org/goobi/production/flow/statistics/hibernate/StatQuestThroughput.java (+0/-7)
src/org/goobi/production/flow/statistics/hibernate/StatQuestUsergroups.java (+0/-3)
src/org/goobi/production/flow/statistics/hibernate/StatQuestVolumeStatus.java (+0/-3)
src/org/goobi/production/flow/statistics/hibernate/UserDefinedFilter.java (+5/-31)
src/org/goobi/production/flow/statistics/hibernate/UserDefinedStepFilter.java (+0/-117)
src/org/goobi/production/flow/statistics/hibernate/UserProjectFilter.java (+3/-19)
src/org/goobi/production/flow/statistics/hibernate/UserTemplatesFilter.java (+0/-3)
src/org/goobi/production/importer/FireburnDataImport.java (+1/-6)
src/org/goobi/production/importer/OpacMassImport.java (+0/-4)
src/org/goobi/production/importer/ProductionDataImport.java (+6/-49)
src/org/goobi/production/search/lucene/LuceneFilter.java (+1/-13)
src/org/goobi/production/search/lucene/LuceneIndex.java (+6/-40)
src/org/goobi/production/search/lucene/LuceneSearch.java (+2/-15)
src/org/goobi/samples/PdfGeneratorSample.java (+0/-11)
test/src/de/sub/goobi/helper/importer/ImportOpacTest.java (+0/-8)
test/src/de/sub/goobi/samples/BenutzerTest.java (+1/-1)
test/src/org/goobi/production/flow/statistics/hibernate/SQLHelperTest.java (+0/-1)
test/src/org/goobi/production/flow/statistics/hibernate/StatQuestCorrectionsTest.java (+0/-4)
test/src/org/goobi/production/flow/statistics/hibernate/StatQuestProductionTest.java (+0/-4)
| summary: |
- Code cleanup: remove unused code + Code cleanup: remove commented out code |
To post a comment you must log in.
