os-networks index fails with quantum

Bug #936797 reported by Tomoe Sugihara
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Tomoe Sugihara

Bug Description

This is because QuantumManager.get_all_networks() violates the contract with network_api, which passes context in to first argument.

--------------------------------
(nova.api.openstack): TRACE: File "/opt/stack/nova/nova/api/openstack/compute/contrib/networks.py", line 80, in index
(nova.api.openstack): TRACE: networks = self.network_api.get_all(context)
(nova.api.openstack): TRACE: File "/opt/stack/nova/nova/network/api.py", line 39, in get_all
(nova.api.openstack): TRACE: {'method': 'get_all_networks'})
(nova.api.openstack): TRACE: File "/opt/stack/nova/nova/rpc/__init__.py", line 69, in call
(nova.api.openstack): TRACE: return _get_impl().call(context, topic, msg, timeout)
(nova.api.openstack): TRACE: File "/opt/stack/nova/nova/rpc/impl_kombu.py", line 624, in call
(nova.api.openstack): TRACE: return rpc_amqp.call(context, topic, msg, timeout, Connection.pool)
(nova.api.openstack): TRACE: File "/opt/stack/nova/nova/rpc/amqp.py", line 335, in call
(nova.api.openstack): TRACE: rv = list(rv)
(nova.api.openstack): TRACE: File "/opt/stack/nova/nova/rpc/amqp.py", line 303, in __iter__
(nova.api.openstack): TRACE: raise result
(nova.api.openstack): TRACE: RemoteError: Remote error: TypeError get_all_networks() got an unexpected keyword argument 'context'
(nova.api.openstack): TRACE: [u'Traceback (most recent call last):\n', u' File "/opt/stack/nova/nova/rpc/amqp.py", line 250, in _process_data\n rval = node_func(context=ctxt, **node_args)\n', u"TypeError: get_all_networks() got an unexpected keyword argument 'context'\n"].
(nova.api.openstack): TRACE:

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/4314

Changed in nova:
assignee: nobody → Tomoe Sugihara (tomoe)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/4314
Committed: http://github.com/openstack/nova/commit/fd280dac74a199e32819dd46efd04d8f3e9fd8ee
Submitter: Jenkins
Branch: master

commit fd280dac74a199e32819dd46efd04d8f3e9fd8ee
Author: Tomoe Sugihara <email address hidden>
Date: Mon Feb 20 17:35:07 2012 +0900

    Fix quantum get_all_networks() signature (lp#936797)

    The base NetworkManager get_all_networks() method requires
    a context argument.

    Change-Id: I8276caf879c3711f411cb16a0fc288cfc9b47965

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → essex-4
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: essex-4 → 2012.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.