Nagios checks NOTE and EXITSTATUS are redundant

Bug #936579 reported by Baron Schwartz
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Percona Monitoring Plugins
Fix Released
High
Baron Schwartz

Bug Description

There's an opportunity for bugs to be introduced in case I set the exit status to one thing and the note's prefix to another. Also, using exit at the end of main() makes it hard to do integration testing.

To resolve this, I will create a new function that sets the exit status based on the prefix of the note. When the note doesn't exist, the exit status will be unknown. This function will be called when the script is executed, but not when main() is run as a function from a sourcing file.

Changed in percona-monitoring-plugins:
status: New → Fix Committed
importance: Undecided → High
assignee: nobody → Baron Schwartz (baron-xaprb)
Changed in percona-monitoring-plugins:
milestone: none → 1.0.0
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.