get_instance_uuids_by_ip_filter is slow, making ec2 metadata slow

[Scott Moser]

As discussed today in openstack-dev [1], the code in instance_uuids_by_ip_filter of nova/network/manager, added [2] is very slow.

In one openstack deployment, it was the primary issue causing metadata service requests to be unbearably slow (over 3 seconds, hitting a timeout on cloud-init requests).

jkoelker suggested paste at [3], and with minor issue fixed at [4]. and it went over reasonably well.

--
[1] http://eavesdrop.openstack.org/irclogs/%23openstack-dev/%23openstack-dev.2012-02-17.log
[2] https://github.com/openstack/nova/commit/8f9453aeb8882509d825c9715fde4e6827b0bbf7
[3] http://paste.openstack.org/show/4860/
[4] http://paste.openstack.org/show/4861/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/4276

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/4276
Committed: http://github.com/openstack/nova/commit/5d3dbb4127785c77604602cd1737b75e30126b6e
Submitter: Jenkins
Branch: master

commit 5d3dbb4127785c77604602cd1737b75e30126b6e
Author: Jason Kölker <email address hidden>
Date: Fri Feb 17 11:07:40 2012 -0600

    Query directly for just the ip

    * Fixes LP934356

    Change-Id: I99b1501b1ef86eafb89fe9416f2668e4325a3656