--verify fails on renamed backups

Bug #934203 reported by Amedee Van Gasse
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
backup2l (Ubuntu)
Fix Released
Undecided
Joachim Wiedorn

Bug Description

--verify succeeds only on the most recent version of the full backup. The md5sum check fails because the filenames in the older .check files are not updated properly when the full backup versions are renamed.

--verify also fails when older full backups are purged and all subsequent backups are renamed. The associated .check files also don't updated accordingly.

For example:
This is a check file when I had 8 full backups and purged full backup
1-7, which renamed full backup 8 to 1:

8f1cd08f7474507751b24d78368f9b32 ./all.801.skipped.gz
5a9c87c7ebba4801c0252b2634d1b33a ./all.801.obsolete.gz
209847ac7775ed5ee54ae714954f2729 ./all.801.list.gz
b1403dd30da8afb4871690aca2c7327e ./all.801.tar.lz
37c91e1872728d15d774fe5778f252a2 ./all.801.new.gz
4b4870721fb61a51a22708520f9a72ba ./all.801.error.gz
88a854a773fe98088ac20fc46058df0d all.1.list.gz

As you can see, 801 did not get renamed to 101.

According to an open bug report upstream, there is a workaround:

"The filenames in the .check file are prepended by ./ while the sed command in backup2l looks for a leading space. Changed the sed command in backup2l to 'sed "s/ \.\/$VOLNAME.$SRC/ \.\/$VOLNAME.$DST/"' to fix the problem."

https://sourceforge.net/tracker/?func=detail&atid=424167&aid=2508322&group_id=39012

However this workaround is not easy to apply because it isn't in a traditional patch form. There is no indication of a line number of where this change should be applied.

Related branches

Changed in backup2l (Ubuntu):
assignee: nobody → Joachim Wiedorn (ad-debian)
status: New → Confirmed
Revision history for this message
Joachim Wiedorn (ad-debian) wrote :

here is the patch which also come with version 1.5-6 (see Debian Sid):

diff -urN s05/backup2l s06/backup2l
--- s05/backup2l 2012-04-27 16:15:33.880477880 +0200
+++ s06/backup2l 2012-04-27 20:45:23.736469131 +0200
@@ -404,7 +404,8 @@
                     fi
                 done
                 for CHK in $VOLNAME.$DST*.check ; do
- sed "s/ $VOLNAME.$SRC/ $VOLNAME.$DST/" < $CHK > $TMP.check
+ cat $CHK | sed "s/ \.\/$VOLNAME.$SRC/ \.\/$VOLNAME.$DST/" |\
+ sed "s/ $VOLNAME.$SRC/ $VOLNAME.$DST/" > $TMP.check
                     mv $TMP.check $CHK
                 done
             fi

Changed in backup2l (Ubuntu):
status: Confirmed → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package backup2l - 1.5-6

---------------
backup2l (1.5-6) unstable; urgency=low

  * Fix verify failure in renamed backups. (LP: #934203)
  * Fix DRIVER_TAR_GPG (thanks to H. Segnitz). (Closes: #665429)
  * Fix problem with MASK_LIST (thanks to G. Kiefer).
  * debian/control: Bump in to Standards Version 3.9.3 (no changes).
  * Update of debian/copyright file.

 -- Joachim Wiedorn <email address hidden> Fri, 27 Apr 2012 19:56:00 +0200

Changed in backup2l (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.