Membership syncing from Launchpad stopped working

Bug #934159 reported by Guilherme Salgado
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Linaro patch metrics
Fix Released
High
James Tunnicliffe

Bug Description

We have a script which syncs the membership information from Launchpad to patches.l.o but it looks like that script only worked because the token used for authentication was for a user who was a member of the registry admins team and thus had access to everyone's email address, regardless of whether they were hidden or not. Now that user is no longer a member of the registry admins team so whenever the script finds a user with a hidden email address it crashes.

Note that pulling email address information from Launchpad is essential because that's the only identifier we have in patches and thus is the only thing we can use to lookup a patch author. If there's no way we can pull email addresses from LP, one alternative would be to require people to log into patches.l.o and register all their email addresses there before they start CCing patches to patches@l.o

Changed in linaro-patchmetrics:
importance: Undecided → High
status: New → Triaged
Revision history for this message
Данило Шеган (danilo) wrote :

Can we instead use the people.getByEmail to directly fetch a person for a particular email address (I believe it should find the appropriate person regardless of their email being hidden or not)?

Revision history for this message
Guilherme Salgado (salgado) wrote : Re: [Bug 934159] Re: Membership syncing from Launchpad stopped working

On 21/02/12 05:51, Данило Шеган wrote:
> Can we instead use the people.getByEmail to directly fetch a person for
> a particular email address (I believe it should find the appropriate
> person regardless of their email being hidden or not)?

That would work but we'd have to rewrite a good chunk of the script
because currently we fetch the details of all members of ~linaro,
including their email addresses, and store that in our DB so that when
they send a patch to patches@l.o we already have their email address and
know who to assign that patch to.

To use getByEmail() we would need to first get a patch from them so that
we have an email address to lookup in Launchpad. When we lookup a new
email address in Launchpad we would also need to check if that email
address doesn't belong to an existing user in our DB, but that can be
easily done via the OpenID URL of users.

This is probably the way to go.

Changed in linaro-patchmetrics:
milestone: none → 2012.03
Changed in linaro-patchmetrics:
status: Triaged → In Progress
assignee: nobody → James Tunnicliffe (dooferlad)
Revision history for this message
James Tunnicliffe (dooferlad) wrote :

We now have code that we are happy with at https://code.launchpad.net/~linaro-infrastructure/linaro-patchmetrics/master and are waiting for a decision about how we are going to continue development. Now the code is done, we need to get deployed. Guess an IS ticket?

Changed in linaro-patchmetrics:
status: In Progress → Fix Committed
Revision history for this message
James Tunnicliffe (dooferlad) wrote :

IS asked to deploy update...

Changed in linaro-patchmetrics:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.