Two default buttons in the remove device confirmation alert
Bug #933577 reported by
Lisette Slegers
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | ||
|---|---|---|---|---|---|---|
| Ubuntu One Control Panel | Status tracked in Trunk | |||||
| Stable-3-0 |
Fix Released
|
Undecided
|
Unassigned | |||
| Trunk |
Fix Released
|
Medium
|
Natalia Bidart | |||
| ubuntuone-control-panel (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | |||
| Precise |
Fix Released
|
Undecided
|
Unassigned | |||
Bug Description
See image attachment. The 'Yes' button should be a secondary button and on the left.
[secondary: Yes] [primary: No]
Please note that this is slightly different than explained in http://
Related branches
lp:~nataliabidart/ubuntuone-control-panel/fix-933576
- Eric Casteleijn (community): Approve
- Roberto Alsina (community): Approve
-
Diff: 1910 lines (+940/-456)24 files modifieddata/qt/controlpanel.ui (+4/-4)
data/qt/images.qrc (+7/-0)
data/qt/side_widget.ui (+214/-0)
data/qt/signin.ui (+115/-152)
data/qt/ubuntuone.qss (+15/-2)
ubuntuone/controlpanel/backend.py (+17/-4)
ubuntuone/controlpanel/gui/__init__.py (+5/-9)
ubuntuone/controlpanel/gui/qt/controlpanel.py (+16/-5)
ubuntuone/controlpanel/gui/qt/gui.py (+1/-1)
ubuntuone/controlpanel/gui/qt/side_widget.py (+81/-0)
ubuntuone/controlpanel/gui/qt/signin.py (+7/-72)
ubuntuone/controlpanel/gui/qt/tests/__init__.py (+24/-4)
ubuntuone/controlpanel/gui/qt/tests/test_account.py (+0/-5)
ubuntuone/controlpanel/gui/qt/tests/test_addfolder.py (+0/-2)
ubuntuone/controlpanel/gui/qt/tests/test_controlpanel.py (+19/-20)
ubuntuone/controlpanel/gui/qt/tests/test_devices.py (+0/-5)
ubuntuone/controlpanel/gui/qt/tests/test_folders.py (+2/-1)
ubuntuone/controlpanel/gui/qt/tests/test_gui.py (+1/-1)
ubuntuone/controlpanel/gui/qt/tests/test_preferences.py (+2/-16)
ubuntuone/controlpanel/gui/qt/tests/test_side_widget.py (+90/-0)
ubuntuone/controlpanel/gui/qt/tests/test_signin.py (+39/-147)
ubuntuone/controlpanel/gui/qt/tests/test_wizard.py (+158/-0)
ubuntuone/controlpanel/gui/qt/wizard.py (+110/-0)
ubuntuone/controlpanel/gui/tests/__init__.py (+13/-6)
Revision history for this message
| Lisette Slegers (lisette-slegers) wrote | #1 |
| Changed in ubuntuone-control-panel: | |
| status: | New → Triaged |
| importance: | Undecided → Medium |
| assignee: | nobody → Diego Sarmentero (diegosarmentero) |
Revision history for this message
| Natalia Bidart (nataliabidart) wrote | #2 |
Revision history for this message
| Natalia Bidart (nataliabidart) wrote | #3 |
| Changed in ubuntuone-control-panel: | |
| assignee: | Diego Sarmentero (diegosarmentero) → Natalia Bidart (nataliabidart) |
| Changed in ubuntuone-control-panel (Ubuntu Precise): | |
| milestone: | none → ubuntu-12.04-beta-2 |
| Changed in ubuntuone-control-panel (Ubuntu Precise): | |
| status: | New → Fix Released |
To post a comment you must log in.
Hello Lisette,
HAving 2 default buttons is definitely a bug and I'm fixing that.
Regarding the order of the buttons, and which one should be the default, after looking at the link you posted, I think we have the correct behavior at the moment, which is:
[ default: No ] [ secondary: Yes ]
I'm basing my conclusion in the fact that the HIG says:
* the "ok" button (for us is "Yes") should be on the right, and not primary (see the image in the HIG).
* the "cancel" button (for us "No") should be on the immediate left of the OK or equivalent button, and is primary.
I'm attaching a screenshot of what we have ATM.
Thanks!