--manifest option crashes vmbuilder

[Antti Kaihola]

The help output as printed by `sudo vmbuilder kvm ubuntu --help` explains the `--manifest` option.

    --manifest=PATH If passed, a manifest will be written to PATH

If I use the option or include it in a configuration file, I get the following output:

2012-02-16 15:44:19,412 INFO : Calling hook: preflight_check
2012-02-16 15:44:19,414 INFO : Calling hook: set_defaults
2012-02-16 15:44:19,415 INFO : Calling hook: bootstrap
2012-02-16 15:48:24,507 INFO : Calling hook: configure_os
2012-02-16 15:49:12,302 INFO : Updating certificates in /etc/ssl/certs... WARNING: Skipping duplicate certificate cert_igca_rsa.pem
2012-02-16 15:49:12,315 INFO : WARNING: Skipping duplicate certificate cert_igca_rsa.pem
2012-02-16 15:49:13,622 INFO : 156 added, 0 removed; done.
2012-02-16 15:49:13,626 INFO : Running hooks in /etc/ca-certificates/update.d....done.
2012-02-16 15:49:18,398 INFO : Creating SSH2 RSA key; this may take some time ...
2012-02-16 15:49:18,474 INFO : Creating SSH2 DSA key; this may take some time ...
2012-02-16 15:49:18,489 INFO : Creating SSH2 ECDSA key; this may take some time ...
2012-02-16 15:49:19,312 INFO : invoke-rc.d: policy-rc.d denied execution of stop.
2012-02-16 15:49:19,315 INFO :
2012-02-16 15:49:19,315 INFO : Warning: Fake initctl called, doing nothing
2012-02-16 15:49:19,317 INFO :
2012-02-16 15:49:19,317 INFO : Warning: Fake initctl called, doing nothing
2012-02-16 15:49:28,549 INFO :
2012-02-16 15:49:28,550 INFO : Current default time zone: 'Europe/Helsinki'
2012-02-16 15:49:28,556 INFO : Local time is now: Thu Feb 16 15:49:28 EET 2012.
2012-02-16 15:49:28,557 INFO : Universal Time is now: Thu Feb 16 13:49:28 UTC 2012.
2012-02-16 15:49:28,557 INFO :
2012-02-16 15:49:49,920 INFO :
2012-02-16 15:49:49,921 INFO : Current default time zone: 'Europe/Helsinki'
2012-02-16 15:49:49,925 INFO : Local time is now: Thu Feb 16 15:49:49 EET 2012.
2012-02-16 15:49:49,925 INFO : Universal Time is now: Thu Feb 16 13:49:49 UTC 2012.
2012-02-16 15:49:49,925 INFO : Run 'dpkg-reconfigure tzdata' if you wish to change it.
2012-02-16 15:49:49,926 INFO :
2012-02-16 15:50:11,689 INFO : restart: Unknown instance:
2012-02-16 15:50:15,961 INFO : Cleaning up
Traceback (most recent call last):
  File "/usr/bin/vmbuilder", line 24, in <module>
    cli.main()
  File "/usr/lib/python2.7/dist-packages/VMBuilder/contrib/cli.py", line 216, in main
    distro.build_chroot()
  File "/usr/lib/python2.7/dist-packages/VMBuilder/distro.py", line 84, in build_chroot
    self.call_hooks('configure_os')
  File "/usr/lib/python2.7/dist-packages/VMBuilder/distro.py", line 67, in call_hooks
    call_hooks(self, *args, **kwargs)
  File "/usr/lib/python2.7/dist-packages/VMBuilder/util.py", line 165, in call_hooks
    getattr(context, func, log_no_such_method)(*args, **kwargs)
  File "/usr/lib/python2.7/dist-packages/VMBuilder/plugins/ubuntu/distro.py", line 157, in configure_os
    self.suite.create_manifest()
  File "/usr/lib/python2.7/dist-packages/VMBuilder/plugins/ubuntu/dapper.py", line 72, in create_manifest
    self.call_hook('fix_ownership', manifest)
AttributeError: 'Oneiric' object has no attribute 'call_hook'

Indeed, if I search for a definition for the `call_hook` method, there are none:

    ack-grep --python "def\s+call_hook\s*\(" /usr/share/pyshared/VMBuilder/

Instead, there are four instances of `call_hooks`:

    ack-grep --python "def\s+call_hooks\s*\(" /usr/share/pyshared/VMBuilder/
    /usr/share/pyshared/VMBuilder/distro.py
    65: def call_hooks(self, *args, **kwargs):

    /usr/share/pyshared/VMBuilder/vm.py
    130: def call_hooks(self, func):

    /usr/share/pyshared/VMBuilder/plugins/__init__.py
    88: def call_hooks(self, *args, **kwargs):

    /usr/share/pyshared/VMBuilder/util.py
    153:def call_hooks(context, func, *args, **kwargs):

This is Linux Mint 12 with python-vm-builder 0.12.4+bzr469-0ubuntu1 from the Oneiric apt repository:

$ apt-cache policy python-vm-builder
python-vm-builder:
  Installed: 0.12.4+bzr469-0ubuntu1
  Candidate: 0.12.4+bzr469-0ubuntu1
  Version table:
 *** 0.12.4+bzr469-0ubuntu1 0
        500 http://archive.ubuntu.com/ubuntu/ oneiric/universe amd64 Packages
        100 /var/lib/dpkg/status

$ dpkg -s python-vm-builder
Package: python-vm-builder
Status: install ok installed
Priority: optional
Section: utils
Installed-Size: 4840
Maintainer: Soren Hansen <email address hidden>
Architecture: all
Source: vm-builder
Version: 0.12.4+bzr469-0ubuntu1
Depends: python (>= 2.5), python-central (>= 0.6.11), qemu-kvm | qemu-kvm-extras, debootstrap (>= 1.0.9), parted, kpartx, ubuntu-keyring, python-cheetah, rsync
Recommends: python-libvirt, devscripts

[Serge Hallyn (serge-hallyn)]

Thanks for reporting this bug. Reproduced in precise.