only warn on bzr version when invoked

[Robert Collins]

 affects /products/bzr-svn

Currently, whenever bzr and bzr-svn's versions are not identical, it
warns about a newer version being available. This is really annoying,
and because its not true that a newer version exists (0.3 of bzr-svn for
0.15 exists, but there is no 'dev' version of the 0.3 code base as far
as I, a simple user, know), and the real bzr-svn trunk is incompatible
with 0.3), it is more than annoying - its something that cannot be
fixed.

I think it would be better to only warn when the svn plugin becomes
active.

I.e. when probe_on_transport calls into svn, and it finds an svn
repository, thats a reasonable time to warn. This would at least make it
only hassle people that are actively using svn repositories.

bzr will take care of warning when an earlier-than-that API is invoked,
because of signature mismatches.

Rob
--
GPG key available at: <http://www.robertcollins.net/keys.txt>.

[Jelmer Vernooij (jelmer)]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Collins wrote:
> Currently, whenever bzr and bzr-svn's versions are not identical, it
> warns about a newer version being available. This is really annoying,
> and because its not true that a newer version exists (0.3 of bzr-svn for
> 0.15 exists, but there is no 'dev' version of the 0.3 code base as far
> as I, a simple user, know), and the real bzr-svn trunk is incompatible
> with 0.3), it is more than annoying - its something that cannot be
> fixed.
I've marked 0.16 as being compatible in the 0.3 branch (for now, at least).

> I think it would be better to only warn when the svn plugin becomes
> active.
I'm not sure how much that would help as probe_on_transport gets run
very often. Running 'bzr ls' in a directory that is part of a bzr tree
will already try to probe for '.svn' subdirectories before hitting the
.bzr directory in the parent directory.

There may be using in doing that though, as well as lazily importing
svn.* to speed up bzr start time.

Cheers,

Jelmer
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iQCVAwUBRf32vAy0JeEGD2blAQJrOAP/SUUPSQiSejbldoSXpOQgKPWQDT6RGWzx
lwgYA4usM2BxYFi50n/gESjo55GMEFMtKkKubu0N+tluSd6esq8kttZKpjyTlZmf
Gi/haN9+6EmDAsLXe9M2aFwMwJvkHfP6WQJunLdN7dyOQ7DS9JKvrXP4/4dg7H5P
ShBdXQ2pwDA=
=/7kG
-----END PGP SIGNATURE-----

[Robert Collins (lifeless)]

On Mon, 2007-03-19 at 02:34 +0000, Jelmer Vernooij wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Robert Collins wrote:
> > Currently, whenever bzr and bzr-svn's versions are not identical, it
> > warns about a newer version being available. This is really annoying,
> > and because its not true that a newer version exists (0.3 of bzr-svn for
> > 0.15 exists, but there is no 'dev' version of the 0.3 code base as far
> > as I, a simple user, know), and the real bzr-svn trunk is incompatible
> > with 0.3), it is more than annoying - its something that cannot be
> > fixed.
> I've marked 0.16 as being compatible in the 0.3 branch (for now, at least).
>
> > I think it would be better to only warn when the svn plugin becomes
> > active.
> I'm not sure how much that would help as probe_on_transport gets run
> very often. Running 'bzr ls' in a directory that is part of a bzr tree
> will already try to probe for '.svn' subdirectories before hitting the
> .bzr directory in the parent directory.
>
> There may be using in doing that though, as well as lazily importing
> svn.* to speed up bzr start time.

Well if it doesn't *find* a svn tree, it should still not warn :). And
yes, having a stub __init__ with lazy imports is a good idea.

Rob
--
GPG key available at: <http://www.robertcollins.net/keys.txt>.

[Jelmer Vernooij (jelmer)]

  status confirmed
  importance low

Setting the importance to low for now, as the current version shouldn't
warn when used with 0.15 or 0.16.

[Jelmer Vernooij (jelmer)]

  status fixcommitted

Thanks for the bug report. This is now fixed in the 0.4 branch.