OpenStack Dashboard (Horizon)

Keystoneclient connection caching broken

Bug #933170 reported by Gabriel Hurley on 2012-02-15

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	OpenStack Dashboard (Horizon)	Fix Released	Medium	Gabriel Hurley	OpenStack Dashboard (Horizon) 2012.1 "essex"

Bug Description

The connection caching mechanism works correctly for non-admin calls, but fails for admin calls. Unfortunately it's the admin calls that need the caching because things like updating a user may involve 3-4 calls to keystone in a single request cycle.

The api.keystone.keystoneclient method needs to be fixed to differentiate the admin requests more intelligently, and cache a standard vs. an admin client separately.

This also needs a real set of unit tests to verify this behavior in the future.

Gabriel Hurley (gabriel-hurley) on 2012-02-15

Changed in horizon:
assignee:	nobody → Gabriel Hurley (gabriel-hurley)
importance:	Undecided → Medium
milestone:	none → essex-4
status:	New → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2012-02-20: Fix merged to horizon (master)

Reviewed: https://review.openstack.org/4223
Committed: http://github.com/openstack/horizon/commit/d2df3ee6ed46b4934fa1a414e4bf16d74ae22ffc
Submitter: Jenkins
Branch: master

commit d2df3ee6ed46b4934fa1a414e4bf16d74ae22ffc
Author: Gabriel Hurley <email address hidden>
Date: Wed Feb 15 15:43:19 2012 -0800

Keystone-related improvements.

* Repairs updating for users and tenants. Fixes bug 912143.

      * Makes connection caching work for admin keystoneclient calls.
        Adds unit tests for horizon.api.keystone.keystoneclient.
        Fixes bug 933170.

      * In conjunction with this keystoneclient review
        https://review.openstack.org/#change,4133
        it takes care of the following bugs as well:

Fixes bug 922394. Fixes bug 881606. Fixes bug 918997.

Change-Id: Id72c99772cd214c33fd1aacf357176cf67c6f473