Incorrect winter handling in serials prediction code

Bug #932155 reported by Dan Wells
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Undecided
Unassigned

Bug Description

The current serials prediction code has an exception for handling cases where 'Winter 2010' is followed by 'Spring 2010' rather than 'Spring 2011'. This exception assumed the more common case of a combined subfield $y, e.g.:

$yps24,21,22,23

In doing so, it incorrectly handled less common cases where the $y is listed separately:

$yps21$yps22$yps23$yps24

This change (with test data) ensures we only check the first $y for our 'early winter' exception.

Fix is here:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dbwells/winter_prediction_fix

This should be backported through 2.0 (it picks cleanly).

Tags: pullrequest
Revision history for this message
Mike Rylander (mrylander) wrote :

Picked into master, 2.1 and 2.0. Thanks, Dan!

Changed in evergreen:
status: New → Fix Committed
Revision history for this message
Mary Moran (mmoran) wrote :

Thanks Dan and Mike: I am working with this intensely and Thanks much for the report Dan and the fix Mike. Most excellent.
Mary

Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.