Original files conversion fails on recent nightlies

[Spooky]

Ever since r7780, possibly even further before that, the conversion of the original Settlers II files seems to fail. If you run RTTR for the first time and have to let it convert the files, the game will then crash as soon as you click something in the main menu. Probably because the 'click' sound isn't actually there, because it looks like the conversion process fails on the audio files.

Console output during conversion: http://pastebin.com/bacTYAij

In order to play, you would need to go back many more revisions, in order to let the files convert properly (and then update back to the recent nightly).

Reproduction steps:

• Delete or move your 'Saved Games\Return To The Roots' folder
• Start s25client.exe, RTTR will convert the files, but you'll see some error messages in the console output during that process
• When RTTR finished the conversion and started the actual application, try to click a button in the main menu, it should crash.

[Spooky (cpp-ema9o-9ei)]

I have tried this on 4 systems so far, everywhere with the same result. Someone else on the forum was experiencing this issue on 2 systems as well. However, Spike was not able to reproduce this apparently.

[Spooky (cpp-ema9o-9ei)]

Ok, I have now tested on one system:

r7800 works
r7811 crashes after the conversion, before the main menu comes up
r7814 crashes on first mouse click in menu (same for r7817 and r7824)

The converted SOUND.LST is indeed different between r7800 and higher releases. It is the same in r7800 and lower releases.

[FloSoft (flosoft)]

we've missed a little null pointer check if loading a sound failed, so this is fixed in rev 7834 now.

the real reason was a missing header caused that some bytes were always swapped, so the game wasnt able to load the sounds anymore, that should be fixed in rev7839 but could break Bug #912427

[Spooky (cpp-ema9o-9ei)]

Hm, but are you talking about the actual client application here, or the sound conversion before that? Because there are definitely differences between r7800 and r7814 regarding the generation of the SOUND.LST file.

[FloSoft (flosoft)]

both

it crashed because we had a bug in the client
the sound was generated wrong before already (but the client should not crash because of this ...)

[Spooky (cpp-ema9o-9ei)]

I see, thx for clarification :)