unity defines panel height all over the place

Bug #928544 reported by Thomi Richards
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Unity
Fix Released
Low
Unassigned
unity (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

In the unity source code, the panel height is defined in several different places. I'm reporting this bug so I remember to clean it up later:

DashController member variable 'panel_height'
HudController member variable 'panel_height'
const int in launcher.cpp: 'panel_height'
const int in PanelIndivatorEntryView.cpp: 'PANEL_HEIGHT'

...and this one:

/home/thomi/code/canonical/unity/hashdefines-are-evil/plugins/unityshell/src/unityshell.cpp:
 1461 int height = 680;
 1462 int launcher_width = optionGetIconSize() + 18;
 1463: int panel_height = 24;
 1464 int x = monitor_geo.x + launcher_width + (monitor_geo.width - launcher_width- width) / 2;
 1465: int y = monitor_geo.y + panel_height + (monitor_geo.height - panel_height - height) / 2;
 1466

Related branches

Omer Akram (om26er)
Changed in unity:
milestone: none → 5.4.0
Changed in unity (Ubuntu):
status: New → In Progress
Changed in unity:
status: Confirmed → In Progress
Tim Penhey (thumper)
Changed in unity:
status: In Progress → Fix Committed
importance: Undecided → Low
Changed in unity:
status: Fix Committed → Fix Released
Changed in unity (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.