Should filter out things like user password and session cookies

Bug #928468 reported by James Westby
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-timeline-django
Fix Released
High
Unassigned

Bug Description

There should be built-in oops filters to redact users passwords, session cookies, etc. that
are part of Django, so that oopses can be shared with reduced worry about what someone
can do with the information they contain.

Some inspiration for how to do this can probably be found in Launchpad (queries to the
session db are redacted there.)

Some helpers for doing this would probably be useful as well, so projects using timeline-django
can easily add their own filters when needed.

Thanks,

James

James Westby (james-w)
Changed in python-timeline-django:
status: New → Triaged
importance: Undecided → High
Revision history for this message
Michael Nelson (michael.nelson) wrote :

Hi James. Just in case it's useful, you can see how Django approaches this for displaying tracebacks (during DEBUG mode):

https://docs.djangoproject.com/en/1.3/ref/settings/#debug

(follow the link to the actual code). Also, something we inherited from the ISD folk (I think ricardo initially) that may help (and atleast, that we'll be able to replace with timeline-django I assume!):

http://bazaar.launchpad.net/~rnr-developers/rnr-server/trunk/view/head:/src/reviewsapp/middleware/exception.py

Revision history for this message
Robert Collins (lifeless) wrote :

Was this fixed in rev 11?

Revision history for this message
James Westby (james-w) wrote :

Yes, though anyone doing non-standard credential handling should be aware that they will
have to do their own filtering.

The system works by filtering queries to the default user and session tables, so if you change
the names or them, or implement your own tables you will have to add filtering of them.

Thanks,

James

Changed in python-timeline-django:
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.