Acq: general search can't always find invoices
Bug #927685 reported by
Lebbeous Fogle-Weekley
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Evergreen |
Fix Released
|
Undecided
|
Lebbeous Fogle-Weekley | ||
2.0 |
Won't Fix
|
Undecided
|
Unassigned | ||
2.1 |
Won't Fix
|
Undecided
|
Unassigned | ||
2.2 |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
Observed by Ben Ostrowsky and Bill Erickson, affecting Evergreen 2.0+:
If you have an invoice that is related to a purchase order only via invoice *items* (which in Evergreen correspond to misc charges, taxes, etc) and not through any invoice *entries* (which correspond to lineitems - books and book-like things), then you won't see that invoice when using the Acquisitions -> General Search and searching for invoices by a field like Purchase Order ID.
I will refactor the core query used by Acq General Search to find invoices by any of their possible relationships to other Acq objects, rather than exclusively via the acq.invoice_entry table.
Changed in evergreen: | |
status: | New → In Progress |
Changed in evergreen: | |
status: | In Progress → New |
milestone: | 2.2.0alpha2 → 2.2.0beta1 |
Changed in evergreen: | |
status: | Fix Committed → Fix Released |
milestone: | none → 2.2.0 |
To post a comment you must log in.
Here's a solution. Testing appreciated.
Acq: improve General Search's ability to find invoices
Invoices in Evergreen have complex relationships with other items. They invoice_ {entry, item} objects.
can be related to lineitems (and ultimately POs and selection lists) by
invoice *entries*, or to PO items (and ultimately etc etc) by invoice
*items*, or directly to purchase orders by either of the above mentioned
acq.
This should make general search more able to find invoices related to
other objects whose fields you might search against in Acquistions
General search.
Here's a diagram that I created to help me think about how to write
these joins:
https:/ /docs.google. com/drawings/ d/15ExkiYvq0skf obbocvPWxwdZkb7 aykEZpLGfbP9P
At Bill Erickson's suggestion, I wound up putting the joins into an IDL view
("acqus") rather than trying to express them in JSON query, which was turnin
into a real time sink.
To prevent this change from making Acq General Search slower than it
was, I've also added indices on all the foreign keys used in the IDL
view, so that the joins should be as fast as possible.
http:// git.evergreen- ils.org/ ?p=working/ Evergreen. git;a=shortlog; h=refs/ heads/user/ senator/ lp-927685