Prevent the deletion of pre-set equalizer options

Bug #926999 reported by Shawn McTear
18
This bug affects 4 people
Affects Status Importance Assigned to Milestone
BeatBox
Fix Released
Medium
Victor Martinez

Bug Description

Currently you can delete pre-set equalizer options with no way to restore them. Its annoying if you accidentally deleted one, with no way to restore it.

Revision history for this message
Victor Martinez (victored) wrote :

Hi Shawn, thanks for your report!

I agree. Not every user knows about 'dconf reset -f /apps/beatbox/equalizer/'
We could either remove the option from the list or add an option to reset them in the preferences dialog.

Changed in beat-box:
assignee: nobody → elementary UX Team (elementary-design)
importance: Undecided → Medium
milestone: none → 1.0
status: New → Confirmed
Revision history for this message
Scott Ringwelski (sgringwe) wrote :

I think the best option is to prevent removing presets.

Revision history for this message
Shawn McTear (syst3mfailur3) wrote :

On top of preventing the deletion of presets, maybe also add a conformation dialogue for when deleting custom options that include the name of what is to be deleted. That why users know for sure what they are deleting.

Revision history for this message
Victor Martinez (victored) wrote :

I'd be more than glad to do it since removing the option for default presets lets us do a nice code cleanup. Please assign me the bug in case you approve.

Revision history for this message
Scott Ringwelski (sgringwe) wrote :

Not allowing removing defaults is definitely a good idea. For the confirmation, we could also reword from "Delete" to "Delete current preset". I will leave the choice up to you.

Revision history for this message
Victor Martinez (victored) wrote :

Let's do it!

Changed in beat-box:
assignee: elementary UX Team (elementary-design) → Victor Eduardo (victored)
status: Confirmed → In Progress
Revision history for this message
Victor Martinez (victored) wrote :

Someone (mananyan on irc.freenode.net) came up with this nice idea http://imagebin.org/197859 which in my opinion is a lot better than having yet-another-dialog

Changed in beat-box:
status: In Progress → Fix Committed
Changed in beat-box:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.