in ltsp, initramfs-tools/scripts/ltsp_nbd does not respect the parameter "nbdserver"

[Zrin Ziborski]

Package: ltsp-server
Version: 5.2.16-0ubuntu7
Maintainer: Stephane Graber <email address hidden>
Release: 11.10 (oneiric)

AFAIU, (/opt/ltsp/.../usr/share/) initramfs-tools/scripts/ltsp_nbd
should respect the "nbdserver" parameter -
the relevant part of the function mountroot() should be amended to
something like

    if [ -n "${nbdroot}" ]; then
        # <host>:<port>
        NBD_ROOT_SERVER=$( echo "${nbdroot}" | sed 's/:.*//')
        NBD_ROOT_PORT=$( echo "${nbdroot}" | sed 's/.*://')
    else
        if [ -n "${nbdserver}" ]; then
                NBD_ROOT_SERVER="${nbdserver}"
        else
                NBD_ROOT_SERVER="${ROOTSERVER}"
        fi
        if [ -n "$nbdname" ]; then
            NBD_ROOT_NAME=${nbdname}
        else
            NBD_ROOT_PORT=${nbdport:-"2000"}
        fi
    fi

The logic behind mountroot() and scripts/ltsp_nbd probably needs
more thorough review and fixing.

best regards,

[Stéphane Graber (stgraber)]

Done in rev1997

=== modified file 'client/initramfs/scripts/ltsp_nbd'
--- client/initramfs/scripts/ltsp_nbd 2011-11-27 04:24:07 +0000
+++ client/initramfs/scripts/ltsp_nbd 2012-02-01 23:38:00 +0000
@@ -38,7 +38,11 @@
         NBD_ROOT_HOST=$( echo "${nbdroot}" | sed 's/:.*//')
         NBD_ROOT_PORT=$( echo "${nbdroot}" | sed 's/.*://')
     else
- NBD_ROOT_HOST="${ROOTSERVER}"
+ if [ -n "${nbdserver}" ]; then
+ NBD_ROOT_HOST="${nbdserver}"
+ else
+ NBD_ROOT_HOST="${ROOTSERVER}"
+ fi
         if [ -n "$nbdname" ]; then
             NBD_ROOT_NAME=${nbdname}
         else

[Alkis Georgopoulos (alkisg)]

Fixed in LTSP 5.3. ltsp_nbd was removed in favor of local-top/nbd.