[6.1] account demo data - wrong periods' definition for field special

[Yannick Vaucher @ Camptocamp]

Hello,

In 6.1 revno 6453

In account/demo/account_demo.xml

Demo data have no opening period and all periods are set to special.

There must be 1 special (opening period) and 12 standard periods.

Here is a patch to fix this.

Regards,
Yannick

[Leonardo Pistone (lepistone)]

Yes, that was reported in the past but I can't find the original bug.
The issue here is that they break the c2c financial reports (i'm sure you know that :))). It is a bug anyway IMO. The problem is that OpenERP allows special periods to overlap, and making all the sample ones special is an intentional hack to make the automated tests work. A cleaner solution would be nice, though.

[Yannick Vaucher @ Camptocamp (yvaucher-c2c)]

Thanks for pointing that out.

I think you are talking about this forgotten bug report in 6.0:
https://bugs.launchpad.net/openobject-addons/+bug/713562

Still a solution is needed in 6.1.

Having demo data that aren't as if they were generated by "Create Month period" of fiscal year make those data wrong :-/
As it is now we cannot test code with those data when we have to exclude opening entries.

Maybe the config wizard should give a warning in case of demo data presence and erase those datas if present. (might be a big erasing dues to related data to descent though everything)
Otherwise, if the purpose of demo data is to be present as the same time as real data a boolean could be needed in open-object to define if it is a demo data or not and having a separared context for each.

Regards,
Yannick

[DJ Patel (OpenERP) (mdi-openerp)]

Hello Yannick Vaucher,

Thanks for reporting and contribution. The solution for this bug is proposed in the branch : https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-924200-mdi/

with following Revision ID and Number.

Revision ID : <email address hidden>
Revision Number : 6456

But, we cannot accept special=False, according to the comment #6 by qdp on this https://bugs.launchpad.net/openobject-addons/+bug/713562 bug.

Thanks and Regards,

Divyesh Makwana(MDI)

[Raphael Collet (OpenERP) (rco-openerp)]

The demo data should not prevent to recreate real periods for the current fiscal year. That's why we use the "special" field in the demo data. Note that these demo periods are necessary for other demo data...

You should not load the demo data on an actual production database.

[Yannick Vaucher @ Camptocamp (yvaucher-c2c)]

So theorically you have either demo data or prod data ?

In that case creating real periods could allow to erase previous periods data.
(A check could even be done to know if demo data were loaded, in order to know if the user is doing a mistake or if he is configuring his erp.)

Still, in my opinion, the current period demo data are invalid to make real tests.
This mostly in case of code that is using "special" field to find a special period. This code cannot be tested correctly.

Yannick

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

Hello,

I thinkg that having all special periods with a special flag is a non-sense. (even if I understand why you did that)
This flag is not just a special flag which allows the overlap, it is also a flag which indicates it is an Opening period.
Reassure me, the yaml tests does not use this periods, does them ?