pt-kill: uninitialized value causes script to exit

[Atle Veka]

pt-kill frequently, about once or twice daily, exits operation after encountering uninitialized variables. Script should properly check all processlist fields and skip execution if any of the fields it requires are "undef".

Debug output:
# Processlist:2161 28382 Checking query $VAR1 = {
# Command => 'Sleep',
# Host => '<FQDN>:<PORT>',
# Id => '182564144',
# Info => undef,
# State => undef,
# Time => undef,
# User => '<USER>',
# db => undef
# };
#
# MasterSlave:2937 28382 Not system user
# MasterSlave:2954 28382 Matches all replication thread: no ; match: 0
Use of uninitialized value in numeric lt (<) at /usr/local/bin/pt-kill line 2180.

In this case it is barfing on the "Time" field.
Line 2179: if ( $find_spec{idle_time} && ($query->{Command} || '') eq 'Sleep' ) {
Line 2180: if ( $query->{Time} < $find_spec{idle_time} ) {

Thanks,
Atle

[Atle Veka (atlev)]

I'm testing this modification.

*** pt-kill Mon Jan 30 14:16:28 2012
--- pt-kill.orig Mon Jan 23 14:22:32 2012
***************
*** 2176,2186 ****
           $matched++;
        }

- if ( ! defined $query->{Time} ) {
- PTDEBUG && _d('query->{Time} is undef, skipping query');
- next QUERY;
- }
-
        if ( $find_spec{idle_time} && ($query->{Command} || '') eq 'Sleep' ) {
           if ( $query->{Time} < $find_spec{idle_time} ) {
              PTDEBUG && _d("Query isn't idle long enough");
--- 2176,2181 ----

[Shahriyar Rzayev (rzayev-sehriyar)]

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PT-457