On XenServer the DomU firewall driver fails with NotImplementedError

[John Garbutt]

If you run with the default flag in devstack:
--firewall_driver=nova.virt.firewall.IptablesFirewallDriver

When trying to launch an instance you get the following error:
(nova.rpc): TRACE: File "/opt/stack/nova/nova/virt/xenapi/vmops.py", line 223, in spawn
(nova.rpc): TRACE: network_info)
(nova.rpc): TRACE: File "/opt/stack/nova/nova/virt/firewall.py", line 133, in prepare_instance_filter
(nova.rpc): TRACE: self.refresh_provider_fw_rules()
(nova.rpc): TRACE: File "/opt/stack/nova/nova/virt/firewall.py", line 361, in refresh_provider_fw_rules
(nova.rpc): TRACE: self._do_refresh_provider_fw_rules()
(nova.rpc): TRACE: File "/opt/stack/nova/nova/utils.py", line 844, in inner
(nova.rpc): TRACE: retval = f(*args, **kwargs)
(nova.rpc): TRACE: File "/opt/stack/nova/nova/virt/firewall.py", line 368, in _do_refresh_provider_fw_rules
(nova.rpc): TRACE: self._build_provider_fw_rules()
(nova.rpc): TRACE: File "/opt/stack/nova/nova/virt/firewall.py", line 381, in _build_provider_fw_rules
(nova.rpc): TRACE: ipv4_rules, ipv6_rules = self._provider_rules()
(nova.rpc): TRACE: File "/opt/stack/nova/nova/virt/firewall.py", line 392, in _provider_rules
(nova.rpc): TRACE: raise NotImplementedError()
(nova.rpc): TRACE: NotImplementedError

Everything works if you use the Dom0 driver, using the following flag:
--firewall_driver=nova.virt.xenapi.firewall.Dom0IptablesFirewallDriver

However, I think it should really be able to work with the other firewall driver too.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/3580

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/3580
Committed: http://github.com/openstack/nova/commit/e08912439e00909c791f6787cce51329b0836901
Submitter: Jenkins
Branch: master

commit e08912439e00909c791f6787cce51329b0836901
Author: Armando Migliaccio <email address hidden>
Date: Tue Jan 31 15:35:44 2012 +0000

    bug 923798: On XenServer the DomU firewall driver fails with NotImplementedError

    Move _provider_rules in the base class. This should be enough to deal with most
    distros on which a domU is based on.

    Change-Id: I738116c5f330c2493c62d8f1f3da39abb3c3ad11