Beat grid does not display if set manually when BPM auto-detection fails

Bug #923377 reported by xorik
22
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Medium
RJ Skerry-Ryan
1.10
Won't Fix
Medium
RJ Skerry-Ryan
1.11
Fix Released
Medium
RJ Skerry-Ryan
2.0
Invalid
Medium
Unassigned

Bug Description

Steps to reproduce:
1) Load some track
2) Run analyse, BPM must be 0 after that
3) Set BMP manual in track properties (e.g. 85bpm)

Expected result: beat grid appears
Actual result: no beat grid

I use latest mixxx from bzr (r2986) on Gentoo linux x86_64

Revision history for this message
xorik (xor29a) wrote :
Revision history for this message
xorik (xor29a) wrote :
summary: - beat grid not displays if analyse not detect BPM
+ Beat grid does not display if no BPM is detected, even if set manually
Changed in mixxx:
status: New → Confirmed
importance: Undecided → Medium
summary: - Beat grid does not display if no BPM is detected, even if set manually
+ Beat grid does not display if set manually when BPM auto-detection fails
RJ Skerry-Ryan (rryan)
Changed in mixxx:
milestone: none → 1.10.1
Revision history for this message
Alef (alef-fela) wrote :

Similarbug, possibly for the same reason:

When BPM is set manually by tapping, while the displayed BPM value changes accordingly, beat grid is not adjusted to the new BPM.

Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Fixed in 1.11.0 and won't fix in 1.10.0 since the fix is tied to the new VAMP system so we can't really backport it.

Changed in mixxx:
status: Confirmed → Fix Committed
assignee: nobody → RJ Ryan (rryan)
milestone: 1.10.1 → none
Revision history for this message
Tomasz Kowalkowski (coval-pl) wrote :

When beat is manually tapped f.ex. 70BPM (auto analyze shows f.ex. 140BPM) and I press Adjust Beatgrid, displayed BPM returns to 140BPM.
I confirm all above also.

RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
thecreaser (thecreaser) wrote :

Version: 1.11.0 r38664
My OS: Mac OSX 10.8.5

Bug persists.
Tracks that have failed the bpm analysis will not display a beat grid on the wave form even when the bpm is entered manually.
If the bmp is entered manually in the deck display the grid is not displayed. The library metadata does not update, bpm stays at zero. The metadata in track properties cannot be set, it remains at zero after apply is clicked.

It seems to be affecting .m4a files encoded by iTunes.

Revision history for this message
jus (jus) wrote :

@thecreaser
Regardless of the original bug, sometimes the BPM detection fails because of a uppercase file extension , e.g. `.M4A` instead `.m4a`. See lp:1274891. You might want to check your files to rule that out.

Revision history for this message
thecreaser (thecreaser) wrote :

@jus
Many thanks, I've now experimented with uppercase & lowercase and special characters in the filename. I've also rewritten the tags in iTunes so everything is lower case and simple.
Same problem exists, screen shot attached to prove it! ;) The screen shot shows the deck bpm count 99, this was entered manually; it also shows no beat grid and it shows the filename is all lower case. All metadata is lower case with no special characters.

The file is fairly meaty in size, one I digitised myself from vinyl: apple lossless audio, 56.1MB, 933kbps, stereo, 16 bit, 44.1kHz.

I made an mp3 version in iTunes of the original file with capitals and special characters- Mixxx analyses it just fine.

I don't think I'm doing anything stupid. Is the bit rate too high for Mixxx? I can send a copy of the offending file if it helps?

Revision history for this message
jus (jus) wrote :

Thanks for taking time to report your findings.
It confirms a report by another user http://mixxx.org/forums/viewtopic.php?f=3&t=3188&p=16961&hilit=alac#p16961

I understand the desired behavior is that Mixxx detects the BPM and therefore automatically displays the correct Beatgrid for ALAC -encoded files. Since it works fine with *.mp3 and *.m4a(AAC), we need to improve the ALAC support.

I`m going to open a new bug, since this one is already closed and invisible by default to visitors.

Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Here's another report confirming this is not fully fixed:
http://www.mixxx.org/forums/viewtopic.php?f=3&t=6128

Revision history for this message
Owen Williams (ywwg) wrote :

Does this affect 1.12? If not that milestone should be removed from the bug

Revision history for this message
xorik (xor29a) wrote :

I think bug is fixed after changing beat detection engine. I not see it for a long time because all tracks BPM are detected now

Revision history for this message
Owen Williams (ywwg) wrote :

marking invalid for 1.12

Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/6259

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.