run-graphite-devel-server.py do not work on solaris 11

[maduma]

the root cause is because 'which' unix cmd still return something even if the located cmd is not found.

$ which dummy
no dummy in /usr/bin /bin /usr/sbin /usr/cluster/bin /usr/sbin /opt/csw/bin

Here the patch files to fix run-graphite-devel-server.py

*** proto/opt/lx/graphite/bin/run-graphite-devel-server.py Fri Jan 27 16:57:54 2012
--- patches/bin/run-graphite-devel-server.py Fri Jan 27 17:05:32 2012
***************
*** 17,29 ****

  graphite_root = args[0]

! for name in ('django-admin', 'django-admin.py'):
! django_admin = os.popen('which %s' % name).read().strip()
! if django_admin: break

- if not django_admin:
- print "Could not find a django-admin script!"
- sys.exit(1)

  python_path = os.path.join(graphite_root, 'webapp')

--- 17,40 ----

  graphite_root = args[0]

! if os.uname()[0] == 'SunOS' and os.uname()[2] == '5.11':
! for name in ('django-admin', 'django-admin.py'):
! if os.popen('which %s' % name).close() == None:
! django_admin = name
! break
! try:
! django_admin
! except NameError:
! print "Could not find a django-admin script!"
! sys.exit(1)
! else:
! for name in ('django-admin', 'django-admin.py'):
! django_admin = os.popen('which %s' % name).read().strip()
! if django_admin: break
! if not django_admin:
! print "Could not find a django-admin script!"
! sys.exit(1)

  python_path = os.path.join(graphite_root, 'webapp')

[Michael Leinartas (mleinartas)]

Fixed in r705

[Nicholas Leskiw (nleskiw)]

The implemented fix breaks compatibility with < python2.7.
We need to make sure to maintain compatibility back to python2.4.

[Nicholas Leskiw (nleskiw)]

more info: subprocess.check_output() is new in python2.7

[Michael Leinartas (mleinartas)]

Thanks Nick, I missed the compatibility issue here.

Fix committed to r706 to use the full-blown subprocess.Popen syntax compatible with python2.4