test suite depends on files in user's $HOME

[Jonathan Nieder]

Trying to build Dulwich 0.8.3, I get three test suite failures: test_default_backends (dulwich.tests.test_config.StackedConfigTests), test_commit_config_identity (dulwich.tests.test_repository.BuildRepoTests), test_get_config_stack (dulwich.tests.test_repository.RepositoryTests). In all three cases, the cause is the same:

  File "dulwich/config.py", line 206, in from_file
    raise ValueError("expected trailing ]")

which presumably means that dulwich.config is having trouble parsing my ~/.gitconfig. Fine, that's already pretty much covered by bug 768687.

This report is about a side-issue: whether dulwich passes tests depends on the content of the invoker's home directory. On one hand we can catch more bugs this way, but on the other hand such lack of reproducibility can make debugging unpleasant. Would it make sense to set HOME to point to a temporary directory populated by the test suite?

[Jelmer Vernooij (jelmer)]

This should now be fixed in trunk. Thanks for the bugreport!

[Jonathan Nieder (jrnieder)]

Jelmer Vernooij wrote:

> This should now be fixed in trunk.

Confirmed. Thanks, that was quick. ;-)