assertion failed in var_expr::remove_set_expr during shutdown

[Till Westmann]

In an extended version of the plan_serializer unit test we run into this error:

#0 0xb52ef0e5 in __cxa_throw () from /usr/lib/i386-linux-gnu/libstdc++.so.6
#1 0xb7144a0f in zorba::assertion_failed (condition=0xb79f3632 "found", file=0xb79f35c0 "/home/tillw/code/zorba/zorba/src/compiler/expression/var_expr.cpp", line=260)
    at /home/tillw/code/zorba/zorba/src/diagnostics/assert.cpp:66
#2 0xb6fc3538 in zorba::var_expr::remove_set_expr (this=0x836abd0, e=0x836ad50) at /home/tillw/code/zorba/zorba/src/compiler/expression/var_expr.cpp:260
#3 0xb6fde15b in zorba::var_set_expr::~var_set_expr (this=0x836ad50, __in_chrg=<value optimized out>) at /home/tillw/code/zorba/zorba/src/compiler/expression/script_exprs.cpp:346
#4 0xb6fde1fb in zorba::var_set_expr::~var_set_expr (this=0x836ad50, __in_chrg=<value optimized out>) at /home/tillw/code/zorba/zorba/src/compiler/expression/script_exprs.cpp:347
#5 0xb6d9758c in zorba::SimpleRCObject::free (this=0x836ad50) at /home/tillw/code/zorba/zorba/src/zorbatypes/rchandle.h:124
#6 0xb78b2821 in zorba::RCObject::removeReference (this=0x836ad50, sharedCounter=0x0, lock=0x0) at /home/tillw/code/zorba/zorba/src/zorbatypes/rchandle.cpp:120
#7 0xb6e6c125 in zorba::rchandle<zorba::expr>::~rchandle (this=0x8376cf8, __in_chrg=<value optimized out>) at /home/tillw/code/zorba/zorba/src/zorbatypes/rchandle.h:169
#8 0xb7339240 in zorba::user_function::~user_function (this=0x8376ca8, __in_chrg=<value optimized out>) at /home/tillw/code/zorba/zorba/src/functions/udf.cpp:89
#9 0xb7339321 in zorba::user_function::~user_function (this=0x8376ca8, __in_chrg=<value optimized out>) at /home/tillw/code/zorba/zorba/src/functions/udf.cpp:91
#10 0xb6d9758c in zorba::SimpleRCObject::free (this=0x8376ca8) at /home/tillw/code/zorba/zorba/src/zorbatypes/rchandle.h:124
#11 0xb78b2821 in zorba::RCObject::removeReference (this=0x8376ca8, sharedCounter=0x0, lock=0x0) at /home/tillw/code/zorba/zorba/src/zorbatypes/rchandle.cpp:120
#12 0xb6ee620b in zorba::rchandle<zorba::function>::~rchandle (this=0x837663c, __in_chrg=<value optimized out>) at /home/tillw/code/zorba/zorba/src/zorbatypes/rchandle.h:169

[Till Westmann (tillw)]

The error can be reproduced in the linked branch.

[Markos Zaharioudakis (markos-za)]

Till, this is probably fixed by now. The bug was probably due to the fact that theSetExprs data member of var_expr was not being serialized at all. However, I cannot check if it is indeed fixed, because you did not tell me how to reproduce the bug. So, I am assigning this bug to you, so that you check it.

[Till Westmann (tillw)]

To test it you could have used
ctest -R plan_serializer
on the related branch.

However, I've merged the trunk into the branch and the problem is indeed fixed.
I'll propose the branch for merging.