Toolbox tools are included on every page
Bug #918587 reported by
Sebastian Meyer
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Goobi.Presentation |
Fix Released
|
Medium
|
Sebastian Meyer |
Bug Description
The registry for tools in the toolbox plugin includes all tools as libs (via includeLibs TS). So the tools are included on every page and not only on pages with the toolbox plugin.
As a workaround you can add the following to your TS template:
page.1000 >
Related branches
lp:~sebastian-meyer/goobi-presentation/bug918587
- Sebastian Meyer: Approve
-
Diff: 69 lines (+3/-9)4 files modifieddlf/ext_localconf.php (+2/-2)
dlf/plugins/toolbox/class.tx_dlf_toolbox.php (+1/-4)
dlf/plugins/toolbox/locallang.xml (+0/-2)
dlf/plugins/toolbox/template.tmpl (+0/-1)
lp:goobi-presentation/1.1
- Sebastian Meyer: Approve
-
Diff: 6190 lines (+1826/-1558) (has conflicts)35 files modifieddlf/common/class.tx_dlf_document.php (+427/-367)
dlf/common/class.tx_dlf_helper.php (+189/-137)
dlf/common/class.tx_dlf_indexing.php (+138/-157)
dlf/common/class.tx_dlf_list.php (+51/-15)
dlf/common/class.tx_dlf_mods.php (+0/-12)
dlf/common/class.tx_dlf_module.php (+12/-14)
dlf/common/class.tx_dlf_plugin.php (+22/-10)
dlf/common/class.tx_dlf_solr.php (+14/-3)
dlf/ext_autoload.php (+30/-30)
dlf/ext_emconf.php (+33/-0)
dlf/ext_tables.php (+146/-145)
dlf/ext_tables.sql (+2/-1)
dlf/ext_tables_static+adt.sql (+1/-2)
dlf/hooks/class.tx_dlf_em.php (+166/-166)
dlf/hooks/class.tx_dlf_hacks.php (+21/-21)
dlf/hooks/class.tx_dlf_tceforms.php (+24/-24)
dlf/hooks/class.tx_dlf_tcemain.php (+50/-58)
dlf/locallang.xml (+0/-2)
dlf/modules/indexing/index.php (+2/-2)
dlf/modules/newclient/index.php (+1/-0)
dlf/modules/newclient/metadata.inc.php (+18/-3)
dlf/plugins/collection/class.tx_dlf_collection.php (+19/-15)
dlf/plugins/feeds/class.tx_dlf_feeds.php (+6/-6)
dlf/plugins/listview/class.tx_dlf_listview.php (+100/-93)
dlf/plugins/listview/locallang.xml (+2/-0)
dlf/plugins/metadata/class.tx_dlf_metadata.php (+91/-87)
dlf/plugins/navigation/class.tx_dlf_navigation.php (+2/-2)
dlf/plugins/oai/class.tx_dlf_oai.php (+124/-91)
dlf/plugins/pageview/class.tx_dlf_pageview.php (+33/-26)
dlf/plugins/search/class.tx_dlf_search.php (+39/-30)
dlf/plugins/search/locallang.xml (+2/-2)
dlf/plugins/statistics/class.tx_dlf_statistics.php (+5/-1)
dlf/plugins/toc/class.tx_dlf_toc.php (+23/-19)
dlf/plugins/toolbox/class.tx_dlf_toolbox.php (+8/-8)
dlf/tca.php (+25/-9)
tags: | added: tx-dlf-toolsdfgviewer tx-dlf-toolspdf |
Changed in goobi-presentation: | |
milestone: | 1.1 → 1.1.rc1 |
Changed in goobi-presentation: | |
status: | Confirmed → In Progress |
Changed in goobi-presentation: | |
status: | In Progress → Fix Committed |
Changed in goobi-presentation: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
See dlf/ext_ localconf. php:
t3lib_extMgm: :addPItoST43( $_EXTKEY, 'plugins/ toolbox/ tools/dfgviewer /class. tx_dlf_ toolsDfgviewer. php', '_toolsDfgviewer', 'includeLib', FALSE);
t3lib_extMgm: :addPItoST43( $_EXTKEY, 'plugins/ toolbox/ tools/pdf/ class.tx_ dlf_toolsPdf. php', '_toolsPdf', 'includeLib', FALSE);
The problem is the "includeLib" parameter which adds the following to every page's TS template:
page.1000 = < plugin. tx_dlf_ toolsDfgviewer
page.1000 = < plugin. tx_dlf_ toolsPdf