compiler warnings

Bug #918337 reported by Martin Gieseking
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
EqualX
Fix Committed
Medium
Unassigned

Bug Description

I'm currently packaging EqualX for Fedora. During the review process [1] a couple of issues have been raised that need some attention. The compiler reports a couple of warnings telling that some non-void methods lack a return statement, e.g:

src/LatexEditor.cpp: In member function 'bool LatexEditor::findNext()':
src/LatexEditor.cpp:210:1: warning: no return statement in function returning non-void [-Wreturn-type]
src/LatexEditor.cpp: In member function 'bool LatexEditor::findPrevious()':
src/LatexEditor.cpp:217:1: warning: no return statement in function returning non-void [-Wreturn-type]

Also, the order of the initializer list of MainWindow::MainWindow() should be corrected.
I've attached two patches that fix the issues. Please have a look if they are sane.

[1] https://bugzilla.redhat.com/show_bug.cgi?id=782786

Revision history for this message
Martin Gieseking (martin-gieseking) wrote :
Changed in equalx:
status: New → Confirmed
importance: Undecided → Medium
milestone: none → 0.5.2
Changed in equalx:
status: Confirmed → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.