gschem: "Close without save" accelerator conflicts with "Cancel"

[Dan White]

When attempting to exit gschem with unsaved changes, the dialog box buttons "Close without save" and "Cancel" both use the "c" keyboard accelerator.

Not seeing the multiple binding may result in the user doing "Alt-c" (to cancel the program exit), hitting enter, and losing changes unintentionally.

[Dan White (etihwnad)]

The attached patch moves the "Close without save" binding to "w".

It canonically lives in the fork:
git://repo.or.cz/geda-gaf/whiteaudio.git

branch "whiteaudio"

commit f5d2698ec7cfe8762d299b549365fe8f94ad4f1f

NOTE: the above fork is frequently mercilessly rebased, the commit ID may change in the future

[Peter TB Brett (peter-b)]

Hi Dan,

Thanks for the patch. Since we're in string freeze for 1.8.0, I've committed this to the master branch rather than the stable-1.8 branch.

[gpleda.org commit robot (gpleda-launchpad-robot)]

Bug was fixed by a commit
git master commit c8dcc3eb30eda791e9ccc26429a82120231ec067
http://git.gpleda.org/?p=gaf.git;a=commit;h=c8dcc3eb30eda791e9ccc26429a82120231ec067

commit c8dcc3eb30eda791e9ccc26429a82120231ec067
Author: Dan White <email address hidden>
Commit: Peter TB Brett <email address hidden>

    gschem: change "Close without save" key-accel to "w"

    Conflicted with "Close" button's accelerator "c" and, due to button ordering,
    was selected first when using "Alt-c". Not noticing the multiple-binding may
    lead to an undesired discard of changes instead of cancelling the gschem exit.

    Closes-bug: lp-918306