dashboard ui bug with alias function.

Bug #917929 reported by Shawn Sterling
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Graphite
Fix Released
Undecided
Daniel Lawrence

Bug Description

In the dashboard ui, if you have an apostrophe (') in the alias description, you can't close the graph via clicking on the X in the top right hand corner.

ie:

alias(metric.goes.here, "yesterday's data")

If you change to:

alias(metric.goes.here, "yesterdays data")

the ui will behaive as normal.

Changed in graphite:
milestone: none → 0.9.10
status: New → Confirmed
Changed in graphite:
assignee: nobody → Daniel Lawrence (dannyla)
Revision history for this message
Michael Leinartas (mleinartas) wrote :

Thanks for the patch. I've used your approach for closing the windows to fix the close overlay button, closing it by index rather than searching for the target string. The button now works for graphs with target that have a single quote in them as well as graphs with duplicate targets.

Revision history for this message
Michael Leinartas (mleinartas) wrote :

Fix committed based on lp:~dannyla/graphite/close-graph-menu committed in r772

Changed in graphite:
status: Confirmed → Fix Committed
Changed in graphite:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.