MySQL/InnoDB migrations broken again

Bug #917205 reported by Thierry Carrez
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Confirmed
Critical
Unassigned

Bug Description

Bug 907878 resulted in the following commit:
Reviewed: https://review.openstack.org/2565
Committed: http://github.com/openstack/nova/commit/2fcbe7e3ab4925ed627bc0e32676e2b6ff98ff3e

It reverted a patch designed to fix bug 904888, so now things are broken again, as reported by Adam Gandelman:
" breaks migration against MySQL using InnoDB: http://paste.ubuntu.com/803153/plain/ "

Vish said:
"so looks like we need to introspect table type and only do the drop on innodb?"

Adam replied:
"Well, I believe at this point in the migrations, all mysql tables are innodb as they are converted in an earlier migration 022_set_engine_mysql_innodb.py. The issue seems to only trigger when mysql is configured as innodb prior to the initial migrations (which is the default now in Ubuntu as of Precise). The commit that this reverts appears to go about in a better way than the hack before, in that it attempts to manually find the correct FK to drop instead of relying on sqlalchemy to resolve it automatically (which apparently it cannot do in the case where InnoDB was used from the get-go)"

Tags: migrations
Revision history for this message
Adam Gandelman (gandelman-a) wrote :

There is a submission in Gerrit to address this, authored by me but submitted by Chuck because I'm having issues with LP+Gerrit currently:

https://review.openstack.org/#change,3110

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.