Doesn't build with latest vala 0.15

[Vincent Untz]

As I assume vala 0.16 will be the default vala for GNOME 3.4, it'd be nice to have deja-dup build with it too :-)

AssistantOperation.vala:196.21-196.25: error: Argument 1: Cannot pass value to reference or output parameter
      buffer.delete(start, line100);
                    ^^^^^
AssistantOperation.vala:201.24-201.27: error: Argument 1: Cannot pass value to reference or output parameter
    buffer.insert_text(iter, log_line, (int)log_line.length);
                       ^^^^
Compilation failed: 2 error(s), 0 warning(s)

[Vincent Untz (vuntz)]

Here's a rather simple patch to fix this. It's unclear to me if this breaks things with vala 0.14 as I don't have this vala version anymore :/

[Michael Terry (mterry)]

Ah, the perils of developing with Vala. The patch does break valac-0.14.

My policy has been to use and continue supporting the last cycle's platform (glib/gtk/vala) during the next cycle. This helps any developers that don't want to run inside jhbuild or Ubuntu+1 or whatever.

(I can get away with this policy since I'm not officially a GNOME module. This policy is also a huge time-saver since I'm not on a treadmill of breakages. It would be neat if more official GNOME apps were allowed to do this.)

I would accept a patch that also adds a bit of vapi magic to let this continue working in valac-0.14 (likely just backporting the changed calls from valac-0.16).

[Michael Terry (mterry)]

(The policy is also great for testing -- I can have a PPA for oneiric that users can run. Another thing that would help other GNOME apps.)

[Michael Terry (mterry)]

Fixed. Now DD exposes the version of valac and uses #if statements to allow compilation on valac-0.14 and valac-0.16.

Please report any other breakages if you find them before I do and I'll fix them quicker next time now that I have this framework.