PATCH: Exceptions thrown when queuing tracks

Bug #916692 reported by Dustin Spicuzza
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Exaile
Fix Released
Medium
Dustin Spicuzza

Bug Description

This is a bit of a grab bag of fixes, but I'll post the stack traces that no longer happen because of this fix:

User Action: On double clicking on the side panel when the queue is highlighted:
    Traceback (most recent call last):
      File "/home/virtuald/src/exaile/exaile/xlgui/main.py", line 300, in <lambda>
        self.on_append_items(items, sort=sort))
      File "/home/virtuald/src/exaile/exaile/xlgui/main.py", line 471, in on_append_items
        offset = len(pl.playlist)
    AttributeError: 'QueuePage' object has no attribute 'playlist'

    Then when you fix that...

    Traceback (most recent call last):
        Traceback (most recent call last):
          File "/home/virtuald/src/exaile/exaile/xlgui/widgets/playlist.py", line 929, in update_icon
            self.set(iter, 1, self.icon_for_row(position))
        TypeError: iter must be a GtkTreeIter

User Action: Drag/drop from playlists panel to playlist:
    Traceback (most recent call last):
      File "/home/virtuald/src/exaile/exaile/xlgui/main.py", line 300, in <lambda>
        self.on_append_items(items, sort=sort))
      File "/home/virtuald/src/exaile/exaile/xlgui/main.py", line 471, in on_append_items
        offset = len(pl.playlist)
    AttributeError: 'QueuePage' object has no attribute 'playlist'

User Action: Hit play when queue page is showing:
    Traceback (most recent call last):
      File "/home/virtuald/src/exaile/exaile/xlgui/main.py", line 798, in on_playpause_button_clicked
        player.QUEUE.set_current_playlist(pl.playlist)
    AttributeError: 'QueuePage' object has no attribute 'playlist'

User Action: Enqueue all tracks in a playlist (right click, left panel):
    Traceback (most recent call last):
      File "/home/virtuald/src/exaile/exaile/xlgui/panel/playlists.py", line 608, in <lambda>
        self.emit('queue-items', self.tree.get_selected_tracks()))
      File "/home/virtuald/src/exaile/exaile/xlgui/panel/playlists.py", line 1192, in get_selected_tracks
        return playlist.get_tracks()
    AttributeError: 'Playlist' object has no attribute 'get_tracks'

These fixes have been pushed to my dj_improvements branch.

Related branches

Revision history for this message
Dustin Spicuzza (dustin-virtualroadside) wrote :
Mathias Brodala (mathbr)
Changed in exaile:
assignee: nobody → Dustin Spicuzza (dustin-virtualroadside)
importance: Undecided → Medium
milestone: none → 0.3.3.0
status: New → Fix Committed
Changed in exaile:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.