The submission_prober script still records an activity when failing

[Marc Tardif]

The submission_prober script records an activity entry in the database each time it is run. This is necessary so that the subsequent run can continue from where the previous one finished. However, when the script fails with an exception, the database transaction is aborted and none of the changes are persisted except for the activity entry which is inserted in its own transaction. The problem is that the subsequent run will not pickup the submissions that were probed in the previous one.

Note that if the activity entry was inserted in the same transaction as the rest of the script, this would result in another problem where subsequent runs would encounter the same exception and never complete. So, the preferred solution would be to catch all exceptions and report proper oops information without aborting the transaction. After the problem is fixed, it should then be possible to prove for failed submission that occured in the past.

[Robert Collins (lifeless)]

You could record activity in two parts perhaps.