Fix for #2389 should be redone properly

[Matt Zimmerman]

The fix of patching smbspool is really just a workaround; the previous behaviour
of smbspool made more sense. Rather than smbspool preferring the environment,
cupsys should avoid passing the printer URI as the first argument (and use only
the environment). This seemed exceedingly nontrivial for Warty, however. We
should revisit it for Hoary.

[Martin Pitt (pitti)]

(In reply to comment #0)
> The fix of patching smbspool is really just a workaround; the previous behaviour
> of smbspool made more sense. Rather than smbspool preferring the environment,
> cupsys should avoid passing the printer URI as the first argument (and use only
> the environment). This seemed exceedingly nontrivial for Warty, however. We
> should revisit it for Hoary.

Upstream had the same idea, this is reported as

  http://www.cups.org/str.php?L933

I filed a samba bug

  https://bugzilla.samba.org/show_bug.cgi?id=2029

to inform the smbspool developers and asked them to coordinate with the CUPS guys.

[Martin Pitt (pitti)]

Samba version 3.0.8 contains our approach (prefer the DEVICE_URI environment
variable) and the bugs I mentioned in the previous post suggest something
similar, so I guess this is just the way upstream solves this now.

So does it make any sense to keep this bug open?

[Matt Zimmerman (mdz)]

The only issue with our fix was that it changed behaviour in a way which was
divergent from upstream. If they have adopted our fix, this is a non-issue.
Thanks for handling the coordination.