OpenLP

cannot delete a theme if it is assigned to a song.

Bug #913508 reported by John Cegalis
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenLP
Fix Released
Medium
Tim Bentley
OpenLP 2.3.1

Bug Description

I tried to delete a theme and got an error that it cannot be deleted because it is assigned to a song. You cannot go through all your songs in your database to remove the association. These two old bugs also referred to the same problem and it was corrected.

https://bugs.launchpad.net/openlp/+bug/693202
https://bugs.launchpad.net/openlp/+bug/700089

Related branches

lp:~trb143/openlp/bugs-2_4b
Raoul Snyman: Approve
Diff: 1230 lines (+351/-312)
31 files modified
openlp/core/__init__.py (+21/-20)
openlp/core/common/settings.py (+5/-42)
openlp/core/common/uistrings.py (+3/-2)
openlp/core/lib/plugin.py (+1/-7)
openlp/core/lib/serviceitem.py (+1/-6)
openlp/core/ui/advancedtab.py (+13/-0)
openlp/core/ui/mainwindow.py (+13/-17)
openlp/core/ui/plugindialog.py (+11/-11)
openlp/core/ui/printserviceform.py (+1/-1)
openlp/core/ui/thememanager.py (+13/-6)
openlp/plugins/bibles/bibleplugin.py (+5/-3)
openlp/plugins/bibles/lib/db.py (+0/-10)
openlp/plugins/bibles/lib/manager.py (+0/-5)
openlp/plugins/custom/customplugin.py (+2/-4)
openlp/plugins/custom/lib/mediaitem.py (+7/-5)
openlp/plugins/images/imageplugin.py (+1/-24)
openlp/plugins/images/lib/mediaitem.py (+8/-8)
openlp/plugins/presentations/presentationplugin.py (+0/-16)
openlp/plugins/remotes/html/openlp.js (+7/-1)
openlp/plugins/remotes/lib/httprouter.py (+6/-3)
openlp/plugins/songs/forms/editsongform.py (+1/-1)
openlp/plugins/songs/lib/mediaitem.py (+3/-3)
openlp/plugins/songs/lib/openlyricsxml.py (+1/-11)
openlp/plugins/songs/lib/songstab.py (+0/-8)
openlp/plugins/songs/songsplugin.py (+2/-5)
tests/functional/openlp_core/test_init.py (+144/-0)
tests/functional/openlp_core_ui/test_advancedtab.py (+69/-0)
tests/functional/openlp_core_ui/test_mainwindow.py (+2/-2)
tests/functional/openlp_core_utils/test_init.py (+1/-1)
tests/functional/test_init.py (+0/-58)
tests/utils/test_bzr_tags.py (+10/-32)
lp:openlp
Revision history for this message
Tim Bentley (trb143) wrote :

Try using the search to find the theme.

Changed in openlp:
status: New → Invalid
status: Invalid → Incomplete
Revision history for this message
Jonathan Corwin (j-corwin) wrote :

Perhaps the error message could mention that? It didn't occur to me either, since I'd forgotten there was a song search by theme as I've never used it.

Revision history for this message
Meinert Jordan (m2j) wrote :

From users point of view it would be best to see a warning dialog with the option to proceed or to cancel (the most advanced version would also offer a list of associated items).

For programmers this would mean either removing the theme from all associated items or using the next level default theme as fall-back in case the the theme does not exist. I'd prefer the later solution, as it also works if users try to copy the songs.sqlite without taking the themes into account.

Jonathan Corwin (j-corwin)
Changed in openlp:
status: Incomplete → Confirmed
importance: Undecided → Low
importance: Low → Wishlist
Tim Bentley (trb143)
Changed in openlp:
assignee: nobody → Tim Bentley (trb143)
status: Confirmed → In Progress
importance: Wishlist → Medium
Tim Bentley (trb143)
Changed in openlp:
milestone: none → 2.3.0
status: In Progress → Fix Committed
Tim Bentley (trb143)
Changed in openlp:
milestone: 2.3.0 → 2.3.1
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.