Invert selecting no objects causes all selected objects to be deselected

Bug #912489 reported by Nathan Schulte
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gEDA
Fix Released
Undecided
Unassigned

Bug Description

Invert selecting on an empty area, either by lasso or by click, causes all selected objects to be deselected. The inverse is not true, nor should it be after the bug is fixed. Invert selecting on nothing should invert select nothing and not change the state of the current selection.

Tags: gschem
Revision history for this message
Nathan Schulte (nmschulte) wrote :
Revision history for this message
Nathan Schulte (nmschulte) wrote :

Here is a patch with some code style and formatting changes I made while researching this bug. This is against current master HEAD, not against the patch submitted as solution for the bug (the above patch).

Revision history for this message
gpleda.org commit robot (gpleda-launchpad-robot) wrote :

Bug was fixed by a commit
git stable-1.8 commit 72be40e1081e56050a81e73e74c5a4e0c645fe3d
http://git.gpleda.org/?p=gaf.git;a=commit;h=72be40e1081e56050a81e73e74c5a4e0c645fe3d

commit 72be40e1081e56050a81e73e74c5a4e0c645fe3d
Author: Nathan Schulte <email address hidden>
Commit: Peter TB Brett <email address hidden>

    gschem: Fix a bug with invert selection

    When invert selecting "nothing", all currently selected objects are
    deselected. This is annoying when you "miss" trying to invert select a
    small group of objects. This is now fixed such that "missing" and
    selecting "nothing" does not deselect everything.

    Closes-bug: lp-912489

Changed in geda:
status: New → Fix Committed
Revision history for this message
gpleda.org commit robot (gpleda-launchpad-robot) wrote :

Bug was fixed by a commit
git master commit 72be40e1081e56050a81e73e74c5a4e0c645fe3d
http://git.gpleda.org/?p=gaf.git;a=commit;h=72be40e1081e56050a81e73e74c5a4e0c645fe3d

commit 72be40e1081e56050a81e73e74c5a4e0c645fe3d
Author: Nathan Schulte <email address hidden>
Commit: Peter TB Brett <email address hidden>

    gschem: Fix a bug with invert selection

    When invert selecting "nothing", all currently selected objects are
    deselected. This is annoying when you "miss" trying to invert select a
    small group of objects. This is now fixed such that "missing" and
    selecting "nothing" does not deselect everything.

    Closes-bug: lp-912489

Peter TB Brett (peter-b)
Changed in geda:
milestone: none → 1.8.0
Peter TB Brett (peter-b)
Changed in geda:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.