Don't mix tabs and spaces in python code
Bug #912369 reported by
mb74
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenShot Video Editor |
Fix Released
|
High
|
Unassigned |
Bug Description
Please replace alls tabs with 4 spaces. You should avoid mixing tabs and spaces. It is a good idea to only use spaces.
Using tabs in python can lead to bugs which are very hard to find.
For a quick code analysis Cython (www.cython.org) can be used:
for x in `find | grep py`; do echo "############### $x:"; cython $x; done
The above command line showed several problems in your code (Version 1.4.0).
With cython you can also improve the speed of time critical python code a lot.
Related branches
Changed in openshot: | |
milestone: | none → 1.4.1 |
importance: | Low → High |
Changed in openshot: | |
status: | Confirmed → Fix Committed |
Changed in openshot: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Agreed. I made the same proposal some times ago.