run_tests should run pep8 by default

Bug #911438 reported by Ed Leafe
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Core Infrastructure
Fix Released
Undecided
Unassigned
OpenStack Identity (keystone)
Fix Released
Undecided
Ed Leafe

Bug Description

Just got burned because my last trivial change introduced a pep8 violation. In nova, run_tests.sh runs the pep8 check if all tests pass; we should do this in keystone, too.

Ed Leafe (ed-leafe)
Changed in keystone:
status: New → In Progress
assignee: nobody → Ed Leafe (ed-leafe)
Revision history for this message
Ed Leafe (ed-leafe) wrote :

I will add a command-line option to skip the pep8 tests, as Ziad has informed me that gerrit runs pep8 separately.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/2763

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/2763
Committed: http://github.com/openstack/keystone/commit/44e9bf7563170531760872983c17585da97d61ea
Submitter: Jenkins
Branch: master

commit 44e9bf7563170531760872983c17585da97d61ea
Author: Ed Leafe <email address hidden>
Date: Tue Jan 3 23:16:11 2012 +0000

    Changes run_tests.sh to also run pep8 by default.

    Can be turned off by passing -P on the command line.
    Fixes bug lp911438.

    Change-Id: Icf719702d496f08b14b7855a1d99ec5419ac63bf

Changed in keystone:
status: In Progress → Fix Committed
Revision history for this message
Thierry Carrez (ttx) wrote :

Adding a CI task to track the potential need now to add "-P" to gerrit/jenkins calls to run_tests

Thierry Carrez (ttx)
Changed in keystone:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in keystone:
milestone: none → essex-3
Revision history for this message
Monty Taylor (mordred) wrote :

This is done now - keystone runs tox directly for unittests at this point.

Changed in openstack-ci:
status: New → Fix Released
Thierry Carrez (ttx)
Changed in keystone:
milestone: essex-3 → 2012.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.