wbinfo_group.pl does not recognize domain names containing spaces

[Brandt B]

Today I ran into the problem that the wbinfo_group.pl script supplied by squid is incable of handling domain names containing spaces. For example the group name "staff" is ok, "domain admins" however is not. I found this great blog post: http://harlekwin.info/2008/12/10/how-to-squid-ad-authentication/ which proposes a fix. I tested the fix and it works.

I have created a corresponding patch and have attached it to this bug-report.
ATTENTION: The patch was created against a version of wbinfo_group.pl, which has the patch from BugReport: 908908 applied.

If you need a patch against the original wbinfo_group.pl, just tell me and I will create one.

Thanks for your efforts

B. Brandt

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "wbinfo_group_new.pl.patch" of this bug report has been identified as being a patch. The ubuntu-reviewers team has been subscribed to the bug report so that they can review the patch. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-reviewers team please also unsubscribe the team from this bug report.

[This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.]

[Brandt B (benedikt-benbra)]

I am sorry for the inconvenience but I just realized that squid replaces all whitespaces with %20 so there is no need to patch anything. Its even the contrary. The above patch does harm if wbinfo_group.pl gets a text-file containing multiple newline seperated groups.

So please just close this bug. I am sorry for the inconvenience and I will make more intense testing the next time before I file a bug report.

[Dave Walker (davewalker)]

@b1, thanks for your work on this - it is appreciated!

closing bug as requested.

Thanks.