SFTP publishing: in case of failure, no artifacts produced at all

[Paul Sokolovsky]

Previously, with Jenkins builtin artifact archiving, in case of build failure, at least artifacts produced so far were archived. This usually inclued source-manifest.xml & pinned-manifest.xml, which sometimes were great help to debug build failures.

Unfortunately, with new SFTP pushing, if a build failure occurs, nothing is archived at all.

[Deepti B. Kalakeri (deeptik)]

Paul,

Can you put a reference to the jobs which fail because of the above problem ?

Thanks!!!
Deepti.

[Paul Sokolovsky (pfalcon)]

No builds fail due to this, this was just a generic "known regression" ticket filed by me (based on my own implementation review) after we switched from builtin Jenkins archiving to snapshots.l.o. As can be seen from the dates, half a year this wasn't a problem for anyone, but yesterday Zach pinged me regarding if this was a known issue, and I referred him to this ticket. Would be nice to have a comment from Danilo why this was set as critical.

As for fixing (or working around) this, this should be quite possible - we just need to re-enable builtin archiving for (only) manifest files, so for (apparently rare) cases when manifests for failed builds are of interests, people can look them up directly on Jenkin build page.

[Данило Шеган (danilo)]

This was set as critical based on priorities from Zach and considering that it was a regression compared to the previous behavior.

[Paul Sokolovsky (pfalcon)]

Ok, so I prepared test build with idea of fix as described above, and it works as expected: https://android-build.linaro.org/builds/~pfalcon/manifest-arc-if-fail/ . Actually, it works better than expected: I though it will require to searching for artifact on Jenkins' build page, but actually frontend page shows those artifact well still, see the link above.

So, all jobs were migrated now.