Test timer-callbacks suffers from a race condition

[Thomas Voß]

/tmp/GoogleTest/src/timer/tests/callbacks/src/test-timer-callbacks.cpp:260: Failure
Mock function called more times than expected - taking default action specified at:
/tmp/GoogleTest/src/timer/tests/callbacks/src/test-timer-callbacks.cpp:71:
    Function call: callback2(1)
          Returns: true
         Expected: to be called once
           Actual: called 38 times - over-saturated and active
/tmp/GoogleTest/src/timer/tests/callbacks/src/test-timer-callbacks.cpp:260: Failure
Mock function called more times than expected - taking default action specified at:
/tmp/GoogleTest/src/timer/tests/callbacks/src/test-timer-callbacks.cpp:71:
    Function call: callback2(1)
          Returns: true
         Expected: to be called once
           Actual: called 39 times - over-saturated and active
/tmp/GoogleTest/src/timer/tests/callbacks/src/test-timer-callbacks.cpp:261: Failure
Mock function called more times than expected - taking default action specified at:
/tmp/GoogleTest/src/timer/tests/callbacks/src/test-timer-callbacks.cpp:70:
    Function call: callback1(0)
          Returns: true
         Expected: to be called once
           Actual: called 20 times - over-saturated and active
/tmp/GoogleTest/src/timer/tests/callbacks/src/test-timer-callbacks.cpp:260: Failure
Mock function called more times than expected - taking default action specified at:
/tmp/GoogleTest/src/timer/tests/callbacks/src/test-timer-callbacks.cpp:71:
    Function call: callback2(1)
          Returns: true
         Expected: to be called once
           Actual: called 40 times - over-saturated and active

[Daniel van Vugt (vanvugt)]

Erm, didn't you verify the test cases passed before committing the change to GoogleTest?

[Thomas Voß (thomas-voss)]

Well, the unit test is not passing but the failure is related to the compiz timers. Thus, we pushed the branch and reported a bug discovered by a unit test.

[Daniel van Vugt (vanvugt)]

Please check for bugs in the new unit tests. Because the old ones (before GoogleTest) pass perfectly.

[Sam Spilsbury (smspillaz)]

On Fri, 23 Dec 2011, Daniel van Vugt wrote:

> Erm, didn't you verify the test cases passed before committing the
> change to GoogleTest?
>

It is a race condition. They pass on some machines (like mine) and not
others unfortunately.

> --
> You received this bug notification because you are a member of Compiz
> Maintainers, which is the registrant for Compiz Core.
> https://bugs.launchpad.net/bugs/908042
>
> Title:
> Test timer-callbacks suffers from a race condition
>
> Status in Compiz Core:
> New
>
> Bug description:
> /tmp/GoogleTest/src/timer/tests/callbacks/src/test-timer-callbacks.cpp:260: Failure
> Mock function called more times than expected - taking default action specified at:
> /tmp/GoogleTest/src/timer/tests/callbacks/src/test-timer-callbacks.cpp:71:
> Function call: callback2(1)
> Returns: true
> Expected: to be called once
> Actual: called 38 times - over-saturated and active
> /tmp/GoogleTest/src/timer/tests/callbacks/src/test-timer-callbacks.cpp:260: Failure
> Mock function called more times than expected - taking default action specified at:
> /tmp/GoogleTest/src/timer/tests/callbacks/src/test-timer-callbacks.cpp:71:
> Function call: callback2(1)
> Returns: true
> Expected: to be called once
> Actual: called 39 times - over-saturated and active
> /tmp/GoogleTest/src/timer/tests/callbacks/src/test-timer-callbacks.cpp:261: Failure
> Mock function called more times than expected - taking default action specified at:
> /tmp/GoogleTest/src/timer/tests/callbacks/src/test-timer-callbacks.cpp:70:
> Function call: callback1(0)
> Returns: true
> Expected: to be called once
> Actual: called 20 times - over-saturated and active
> /tmp/GoogleTest/src/timer/tests/callbacks/src/test-timer-callbacks.cpp:260: Failure
> Mock function called more times than expected - taking default action specified at:
> /tmp/GoogleTest/src/timer/tests/callbacks/src/test-timer-callbacks.cpp:71:
> Function call: callback2(1)
> Returns: true
> Expected: to be called once
> Actual: called 40 times - over-saturated and active
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/compiz-core/+bug/908042/+subscriptions
>