SIP2 non-hold transit checkins do not report destination on first checkin

[Thomas Berezansky]

The problem is that the "Route Item" event has the destination stored on the checkin object, not the item object.

Secondary checkins have the destination loaded by the item object automatically. Hold pickup library based checks later in the function use the item destination location variable and thus work on the first try.

The branch below fixes this, removing the checkin's destination location variable entirely and using only the item's (which is the only one that should matter).

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/tsbere/fix_sip2_checkin_transit

[Sarah Chodrow (sarah-chodrow)]

Tested, signed off, and pushed to working repo at user/sal/fix_sip2_checkin_transit_signoff

[Dan Scott (denials)]

Thanks, Sarah and Thomas!

Committed to master.