exporting bookmarks broken

Bug #906837 reported by Mark__T
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Midori Web Browser
Fix Released
High
Unassigned

Bug Description

Since 0.4.3 exporting bookmarks only creates an empty xbel template:
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE xbel PUBLIC "+//IDN python.org//DTD XML Bookmark Exchange Language 1.0//EN//XML" "http://www.python.org/topics/xml/dtds/xbel-1.0.dtd">
<xbel version="1.0" xmlns:midori="http://www.twotoasts.de">
<info>
<metadata owner="http://www.twotoasts.de"/>
</info>
</xbel>

Tags: bookmarks
Revision history for this message
Mark__T (mark-trompell) wrote :

Somewhat expected the responsible commit which introduced it is:

commit e4963aa324bb8021550366eca814346baecda03d
Author: Christian Dywan
Date: Wed Nov 23 00:23:41 2011 +0100

    Introduce midori_array_query to unify bookmark queries

    This ensures querying is consistently quoted and ordered.

Revision history for this message
Cris Dywan (kalikiana) wrote :

So I pushed a fix. The fact is that the export function expected a separate db pointer and an empty rather than the source bookmark array. I replaced it with a slightly enhanced query function that can handle child items with the right semantics.

Changed in midori:
status: New → Fix Committed
importance: Undecided → High
tags: added: bookmarks
Revision history for this message
Mark__T (mark-trompell) wrote :

tested on top of 0.4.3, looks good.

Cris Dywan (kalikiana)
Changed in midori:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.