sync bpm without syncing to beatgrid

Bug #905800 reported by Jonas Clemens
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Wishlist
RJ Skerry-Ryan

Bug Description

in trunk, when you press the sync button, the track jumps forward or backward to match the beatgrids with the other track.

if the beatgrids aren't placed correctly, this behavior isn't very useful.

so i thought the small "quantize" toggle button should decide whether to skip to the next beatgrid or not.

i wrote a patch. not sure if i did it right, though.

Related branches

Revision history for this message
Jonas Clemens (jonasclemens) wrote :
Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Hey Jonas,

Thanks for the patch.

I think that it may confuse things to make the sync behavior tied to quantize. I would prefer it if there were two sync COs -- one for syncing with phase adjustment and one for without. That way we could make the sync button left-click to sync BPM/phase and right click to sync just BPM.

Changed in mixxx:
status: New → Confirmed
importance: Undecided → Wishlist
RJ Skerry-Ryan (rryan)
Changed in mixxx:
milestone: none → 1.10.0
RJ Skerry-Ryan (rryan)
Changed in mixxx:
assignee: nobody → RJ Ryan (rryan)
Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Two new controls are in the 1.10 branch now "beatsync_tempo" and "beatsync_phase". I made all skins call beatsync_tempo on right-click of the sync button, so the use-case of tempo-sync alone will still be available in 1.10.0.

Thanks Jonas!

Changed in mixxx:
status: Confirmed → Fix Committed
RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/6189

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.