Minor issue: Library Scanner dialog text jumping

Bug #905667 reported by Ilkka Tuohela
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Low
Kevin Wern

Bug Description

Very minor and cosmetic issue, but easy to fix as well so I'll report it.

With long filenames, the filename entry text in library scanner dialog jumps up and down, and text shown is clipped as well (it has height of one line and two lines are shown in this area centered vertically).

Two minor changes in LibraryScannerDlg::LibraryScannerDlg should fix this:
- Set QLabel* pCurrent aligned to the top in properties
- Give it 2 * height of current font size default height

I noticed bug 670109 is talking about integrating this dialog to main window: until this change is done, this minor cleanup should make the current dialog better, but if work is already ongoing getting rid of the dialog, just forget this bug report.

Tags: easy polish
jus (jus)
Changed in mixxx:
status: New → Confirmed
importance: Undecided → Low
milestone: none → 1.10.1
RJ Skerry-Ryan (rryan)
Changed in mixxx:
milestone: 1.10.1 → none
tags: added: easy polish
Revision history for this message
Kevin Wern (kevin-m-wern) wrote :

Did the quick fix here: https://github.com/kwern/mixxx/compare/quicklibfix

(Also, I will get the rating stuff done in the next day or so. Been a crazy couple of weeks)

Changed in mixxx:
assignee: nobody → Kevin Wern (kevin-m-wern)
Revision history for this message
Kevin Wern (kevin-m-wern) wrote :

Whoops, didn't link the pull request.

https://github.com/mixxxdj/mixxx/pull/224

Max Linke (max-linke)
Changed in mixxx:
status: Confirmed → Fix Committed
RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Fix Committed → Fix Released
RJ Skerry-Ryan (rryan)
Changed in mixxx:
milestone: none → 2.0.0
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/6186

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.