Currently when submitting a non-arb app, if you haven't yet entered payment details you are redirected to the payment screen (bug 865506), which is nice but there are some points that should/need to be improved (particularly 3):
1) There are multiple messages displayed which looks confusing - see attached screenshot
2) The help-text for the paypal email implies that it is not required, yet it is required
3) When you submit your account details, you are left on the account details page with a "Your account details were updated successfully" message, but no mention of the app I was trying to submit - and it has not been submitted.
I think we could improve (3) greatly by passing '?submitted_app=123&submitter_notes=Make+sure+you+do+X' in the url when we redirect to the payment screen. This would mean we could:
* Replace the default validation error with the "Payment details are required..." message, rather than adding to it.
* avoid all the red error classes on the screen and indicating the required fields in a less "YOU MADE A MISTAKE" way :-)
* Change the button from "Update my account" to "Update my account and submit app"
* Submit the app for review when they successfully update their account and redirect to the app details with a message.
Note: I initially thought it strange that we also require devs to enter their payment details when submitting a non-arb-yet-free app, but dpitkin says that's what we want - in fact, we may even want all devs to enter this info thee first time (even for arb apps): https://pastebin.canonical.com/57280/
QA Notes:
1) As a new developer, add a commercial app, move through to the preview page
2) scroll down and enter some submitter notes, then hit submit for review
3) you should be redirected to your payment details (and address etc.) Enter the required fields and click submit
4) you should be redirected back to the submit section of the app details, and the original submitter notes should still be there.
After a pre-imp with achuni, we decided to quickly fix (3) by ensuring that we redirect abck to the app details. So the above branch does that, specifically, to the #submit section of the details, and retains any submitter notes that were entered by the dev.